Proxmox/proxmox-backup
5
0
Fork 0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-03-20 22:50:18 +03:00
Code Releases Activity
proxmox-backup/www/window/GCJobEdit.js

29 lines
671 B
JavaScript
Raw Permalink Normal View History

fix #3217: ui: global prune and gc job view In the global datastore view, extend the prune view to display gc job status as a table. Use the same widget in the local view and dispaly gc job status as a single row. The local PruneAndGC view is parameterized (cbind) with the datastore. At initialization the only row is selected. This allows the rest of the grid to act on selected rows and it requires far less special casing if the datastore is set on the view or not. Having a single row always selected and therefore highlighted, is visually not appealing. Therefore, highlighting of selected rows is disabled in the local view. Moved GCView to different file and enhanced it with last, next run, status and duration. Added button to show task log. Changed `render_task_status()` to also take in account upids stored in other 'columns'. Signed-off-by: Stefan Lendl <s.lendl@proxmox.com> [LW: include ref to bugzilla in commit message] Signed-off-by: Lukas Wagner <l.wagner@proxmox.com> Originally-by: Gabriel Goller <g.goller@proxmox.com> Tested-by: Gabriel Goller <g.goller@proxmox.com> Reviewd-by: Gabriel Goller <g.goller@proxmox.com> Tested-by: Lukas Wagner <l.wagner@proxmox.com> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
2024-04-18 12:16:58 +02:00
Ext.define('PBS.window.GCJobEdit', {
extend: 'Proxmox.window.Edit',
alias: 'widget.pbsGCJobEdit',
mixins: ['Proxmox.Mixin.CBind'],
userid: undefined,
onlineHelp: 'maintenance_gc',
isAdd: false,
subject: gettext('Garbage Collect Schedule'),
cbindData: function(initial) {
let me = this;
me.datastore = encodeURIComponent(me.datastore);
me.url = `/api2/extjs/config/datastore/${me.datastore}`;
me.method = 'PUT';
me.autoLoad = true;
return {};
},
items: {
xtype: 'pbsCalendarEvent',
name: 'gc-schedule',
fieldLabel: gettext("GC Schedule"),
ui: gc job edit: fix i18n gettext usage String concatenating a variable with some static text as gettext parameter cannot really work, and it also does not make sense to do most of the time, as even if we'd use some overly generic format string like '{0} (disabled)', it would be not easy to translate correctly in all languages in such a generic way. So just use the actual full string, which is already contained in our translation catalogue anyway… Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-06-18 16:12:14 +02:00
emptyText: gettext('none (disabled)'),
fix #3217: ui: global prune and gc job view In the global datastore view, extend the prune view to display gc job status as a table. Use the same widget in the local view and dispaly gc job status as a single row. The local PruneAndGC view is parameterized (cbind) with the datastore. At initialization the only row is selected. This allows the rest of the grid to act on selected rows and it requires far less special casing if the datastore is set on the view or not. Having a single row always selected and therefore highlighted, is visually not appealing. Therefore, highlighting of selected rows is disabled in the local view. Moved GCView to different file and enhanced it with last, next run, status and duration. Added button to show task log. Changed `render_task_status()` to also take in account upids stored in other 'columns'. Signed-off-by: Stefan Lendl <s.lendl@proxmox.com> [LW: include ref to bugzilla in commit message] Signed-off-by: Lukas Wagner <l.wagner@proxmox.com> Originally-by: Gabriel Goller <g.goller@proxmox.com> Tested-by: Gabriel Goller <g.goller@proxmox.com> Reviewd-by: Gabriel Goller <g.goller@proxmox.com> Tested-by: Lukas Wagner <l.wagner@proxmox.com> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
2024-04-18 12:16:58 +02:00
},
});
Copy Permalink