From 08d136e069dd5b6d29f431fa6d2f3c9eafcef824 Mon Sep 17 00:00:00 2001 From: Christian Ebner Date: Wed, 4 Dec 2024 09:31:47 +0100 Subject: [PATCH] client: backup: remove unnecessary clone for backup reader This was introduced by commit fdea4e53 ("client: implement prepare reference method") to read a reference metadata archive for detection of unchanged, reusable files when using change detection mode set to `metadata`. Avoid unnecessary cloning of the atomic reference counted `BackupReader` instance, as it is used exclusively for this codepath. Signed-off-by: Christian Ebner --- proxmox-backup-client/src/main.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs index 9daa513f..632a2917 100644 --- a/proxmox-backup-client/src/main.rs +++ b/proxmox-backup-client/src/main.rs @@ -1107,7 +1107,7 @@ async fn create_backup( &target, manifest.clone(), &client, - backup_reader.clone(), + backup_reader, crypt_config.clone(), crypto.mode, ) @@ -1310,7 +1310,7 @@ async fn prepare_reference( let most_used = metadata_ref_index.find_most_used_chunks(8); let file_info = manifest.lookup_file_info(&target)?; let chunk_reader = RemoteChunkReader::new( - backup_reader.clone(), + backup_reader, crypt_config.clone(), file_info.chunk_crypt_mode(), most_used,