Proxmox/proxmox-backup
5
0
Fork 0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-02-26 21:57:33 +03:00
Code Releases Activity

gc: improve lost+found comment

Browse Source 
this sounded like we need to skip lost+found to avoid pruning too many chunks,
while the opposite is true - it's safe to skip lost+found on EPERM without
pruning too many chunks, but this is not the case for all EPERM situations..

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2023-09-12 11:29:11 +02:00
parent 0d69dcb497
commit 8fcd709cf2
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pbs-datastore/src/datastore.rs
View File

@ -875,10 +875,11 @@ impl DataStore {
};
if inner.kind() == io::ErrorKind::PermissionDenied {
if err.depth() <= 1 && path.ends_with("lost+found") {
// allow skipping ext4 fsck-directory on EPERM only, otherwise we might prune
// too many chunks. E.g., if users messed up with owner/perms on a rsync
// allow skipping of (root-only) ext4 fsck-directory on EPERM ..
return Ok(());
}
// .. but do not ignore EPERM in general, otherwise we might prune too many chunks.
// E.g., if users messed up with owner/perms on a rsync
bail!("cannot continue garbage-collection safely, permission denied on: {path:?}");
} else {
bail!("unexpected error on datastore traversal: {inner} - {path:?}");