Proxmox/proxmox-backup
5
0
Fork 0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-01-08 21:18:07 +03:00
Code Releases Activity

bin: manager: add (un)mount command

Browse Source 
We can't just directly delegate these commands to the API endpoints
since both mounting and unmounting are done in a worker, and that one
would be killed when the parent ends. In this case that would be the CLI
process, which basically ends right after spwaning the worker.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
This commit is contained in:
Hannes Laimer 2024-11-25 17:21:56 +01:00 committed by Thomas Lamprecht
parent 76609915d6
commit 919925519a
2 changed files with 88 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pbs-config/src/datastore.rs
View File

@ -62,6 +62,20 @@ pub fn complete_datastore_name(_arg: &str, _param: &HashMap<String, String>) ->
}
}
pub fn complete_removable_datastore_name(
_arg: &str,
_param: &HashMap<String, String>,
) -> Vec<String> {
match config() {
Ok((data, _digest)) => data
.sections
.into_iter()
.filter_map(|(name, (_, c))| c.get("backing-device").map(|_| name))
.collect(),
Err(_) => Vec::new(),
}
}
pub fn complete_acl_path(_arg: &str, _param: &HashMap<String, String>) -> Vec<String> {
let mut list = vec![
String::from("/"),

74
src/bin/proxmox_backup_manager/datastore.rs
View File

@ -42,6 +42,34 @@ fn list_datastores(param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<Valu
Ok(Value::Null)
}
#[api(
protected: true,
input: {
properties: {
store: {
schema: DATASTORE_SCHEMA,
},
digest: {
optional: true,
schema: PROXMOX_CONFIG_DIGEST_SCHEMA,
},
},
},
)]
/// Mount a removable datastore.
async fn mount_datastore(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> {
param["node"] = "localhost".into();
let info = &api2::admin::datastore::API_METHOD_MOUNT;
let result = match info.handler {
ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
_ => unreachable!(),
};
crate::wait_for_local_worker(result.as_str().unwrap()).await?;
Ok(())
}
#[api(
input: {
properties: {
@ -101,6 +129,34 @@ async fn create_datastore(mut param: Value) -> Result<Value, Error> {
Ok(Value::Null)
}
#[api(
protected: true,
input: {
properties: {
store: {
schema: DATASTORE_SCHEMA,
},
digest: {
optional: true,
schema: PROXMOX_CONFIG_DIGEST_SCHEMA,
},
},
},
)]
/// Unmount a removable datastore.
async fn unmount_datastore(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> {
param["node"] = "localhost".into();
let info = &api2::admin::datastore::API_METHOD_UNMOUNT;
let result = match info.handler {
ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await?,
_ => unreachable!(),
};
crate::wait_for_local_worker(result.as_str().unwrap()).await?;
Ok(())
}
#[api(
protected: true,
input: {
@ -191,6 +247,15 @@ async fn update_datastore(name: String, mut param: Value) -> Result<(), Error> {
pub fn datastore_commands() -> CommandLineInterface {
let cmd_def = CliCommandMap::new()
.insert("list", CliCommand::new(&API_METHOD_LIST_DATASTORES))
.insert(
"mount",
CliCommand::new(&API_METHOD_MOUNT_DATASTORE)
.arg_param(&["store"])
.completion_cb(
"store",
pbs_config::datastore::complete_removable_datastore_name,
),
)
.insert(
"show",
CliCommand::new(&API_METHOD_SHOW_DATASTORE)
@ -201,6 +266,15 @@ pub fn datastore_commands() -> CommandLineInterface {
"create",
CliCommand::new(&API_METHOD_CREATE_DATASTORE).arg_param(&["name", "path"]),
)
.insert(
"unmount",
CliCommand::new(&API_METHOD_UNMOUNT_DATASTORE)
.arg_param(&["store"])
.completion_cb(
"store",
pbs_config::datastore::complete_removable_datastore_name,
),
)
.insert(
"update",
CliCommand::new(&API_METHOD_UPDATE_DATASTORE)