Proxmox/proxmox-backup
5
0
Fork 0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-03-08 04:58:30 +03:00
Code Releases Activity

ui: system config: fix deleting DNS entries

Browse Source 
While PVE and PMG use a rather brittle "replace whole config" style on
their DNS entry CRUD API, the PBS one was made with a per-entry level
granularity, so that single entries can modified, or deleted, without
touching the others.

But the UI from the widget-toolkit was made for the older PVE/PMG
behavior and did  not sent along the delete-array of to-be-deleted
keys.

Since widget-toolkit commit 8d161ac ("dns: update comment to avoid
coupling to downstream dependency") the DNS edit window supports
opting into that by setting the new `deleteEmpty` config parameter.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 [ TL: expand commit message ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Dominik Csapak 2024-03-01 10:03:41 +01:00 committed by Thomas Lamprecht
parent 9d66b5b5c3
commit 9481cc26b4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
www/SystemConfiguration.js
View File

@ -31,6 +31,7 @@ Ext.define('PBS.SystemConfiguration', {
},
{
xtype: 'proxmoxNodeDNSView',
deleteEmpty: true,
title: gettext('DNS'),
nodename: 'localhost',
},