Proxmox/proxmox-backup
5
0
Fork 0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-01-20 14:03:53 +03:00
Code Releases Activity

ui: utils: make parseMaintenanceMode more robust

Browse Source 
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
This commit is contained in:
Hannes Laimer 2024-11-25 17:22:04 +01:00 committed by Thomas Lamprecht
parent c74b289174
commit b1b6489233
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
www/Utils.js
View File

@ -740,14 +740,29 @@ Ext.define('PBS.Utils', {
return `${icon} ${value}`;
},
// FIXME: this "parser" is brittle and relies on the order the arguments will appear in
/**
* Parses maintenance mode property string.
* Examples:
* "offline,message=foo" -> ["offline", "foo"]
* "offline" -> ["offline", null]
* "message=foo,offline" -> ["offline", "foo"]
* null/undefined -> [null, null]
*
* @param {string|null} mode - Maintenance mode string to parse.
* @return {Array<string|null>} - Parsed maintenance mode values.
*/
parseMaintenanceMode: function(mode) {
let [type, message] = mode.split(/,(.+)/);
type = type.split("=").pop();
message = message ? message.split("=")[1]
.replace(/^"(.*)"$/, '$1')
.replaceAll('\\"', '"') : null;
return [type, message];
if (!mode) {
return [null, null];
}
return mode.split(',').reduce(([m, msg], pair) => {
const [key, value] = pair.split('=');
if (key === 'message') {
return [m, value.replace(/^"(.*)"$/, '$1').replace(/\\"/g, '"')];
} else {
return [value ?? key, msg];
}
}, [null, null]);
},
renderMaintenance: function(mode, activeTasks) {