Proxmox/proxmox-backup
5
0
Fork 0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-01-03 01:18:02 +03:00
Code Releases Activity

api: disks: directory: fail if mount unit already exists

Browse Source 
Without this check, if a mount unit is present, but the file system is
not mounted, it will just get overwritten. The unit might belong to an
existing datastore.

There already is a check against a duplicate datastore, but only after
the mount unit is already overwritten and having the add-datastore
flag present is not a precondition to trigger the issue.

The check is done even if the newly created directory datastore is
removable. While in that case, the mount unit is not overwritten, the
conflict for the mount point is still present, so it is nice to fail
early.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner 2024-11-27 17:06:37 +01:00 committed by Thomas Lamprecht
parent a7792e16c5
commit d3910e1334
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/api2/node/disks/directory.rs
View File

@ -204,6 +204,11 @@ pub fn create_datastore_disk(
}
}
let (mount_unit_path, _) = datastore_mount_unit_path_info(&mount_point);
if std::path::PathBuf::from(&mount_unit_path).exists() {
bail!("systemd mount unit '{mount_unit_path}' already exists");
}
let upid_str = WorkerTask::new_thread(
"dircreate",
Some(name.clone()),