Proxmox/proxmox-backup
5
0
Fork 0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-01-05 09:17:59 +03:00
Code Releases Activity

push: improve error messages

Browse Source 
the error message for failure to sync the whole namespace was too long, so
split it into two lines and make it a warning.

the namespace creation one lacked context (that the error was caused by the
remote side or the connection) and had too much (the datastore, which is
already logged very often) at the same time.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2024-11-21 11:44:56 +01:00
parent a5350595fc
commit e0ddb88cb7
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/server/push.rs
View File

@ -305,12 +305,11 @@ async fn check_or_create_target_namespace(
if !parent.is_root() {
args["parent"] = serde_json::to_value(parent.clone())?;
}
let target_store_and_ns = print_store_and_ns(params.target.repo.store(), &current);
match params.target.client.post(&api_path, Some(args)).await {
Ok(_) => info!("Created new namespace on target: {target_store_and_ns}"),
Err(err) => bail!(
"Sync into {target_store_and_ns} failed - namespace creation failed: {err}"
),
Ok(_) => info!("Created new namespace on target: {current}"),
Err(err) => {
bail!("Remote creation of namespace {current} failed, remote returned: {err}")
}
}
parent = current;
}
@ -372,7 +371,8 @@ pub(crate) async fn push_store(mut params: PushParameters) -> Result<SyncStats,
)
.await
{
info!("Cannot sync {source_store_and_ns} into {target_store_and_ns} - {err}");
warn!("Encountered error: {err}");
warn!("Failed to sync {source_store_and_ns} into {target_store_and_ns}!");
errors = true;
continue;
}