5
0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-01-03 01:18:02 +03:00
Go to file
Christian Ebner 6771869cc1 client/server: use dedicated api type for all archive names
Instead of using the plain String or slices of it for archive names,
use the dedicated api type and its methods to parse and check for
archive type based on archive filename extension.

Thereby, keeping the checks and mappings in the api type and
resticting function parameters by the narrower wrapper type to reduce
potential misuse.

Further, instead of declaring and using the archive name constants
throughout the codebase, use the `BackupArchiveName` helpers to
generate the archive names for manifest, client logs and encryption
keys.

This allows for easy archive name comparisons using the same
`BackupArchiveName` type, at the cost of some extra allocations and
avoids the currently present double constant declaration of
`CATALOG_NAME`.

A positive ergonomic side effect of this is that commands now also
accept the archive type extension optionally, when passing the archive
name.

E.g.
```
proxmox-backup-client restore <snapshot> <name>.pxar.didx <target>
```
is equal to
```
proxmox-backup-client restore <snapshot> <name>.pxar <target>
```

The previously default mapping of any archive name extension to a blob
has been dropped in favor of consistent mapping by the api type
helpers.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>

FG: use LazyLock for constant archive names
FG: add missing import

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2024-11-22 13:47:05 +01:00
.cargo cargo config: add debug=true 2024-06-25 14:21:58 +02:00
debian bump version to 3.2.11-1 2024-11-21 12:47:11 +01:00
docs docs: client: fix formatting by using double ticks 2024-11-21 17:02:28 +01:00
etc etc/pbs-enterprise.list: change to bookworm 2023-06-26 22:12:53 +02:00
examples update to proxmox-log 0.2 and proxmox-rest-server 0.7 2024-07-24 14:53:07 +02:00
pbs-api-types api types: introduce BackupArchiveName type 2024-11-22 13:46:35 +01:00
pbs-buildcfg use new apt/apt-api-types crate 2024-07-08 15:28:59 +02:00
pbs-client client/server: use dedicated api type for all archive names 2024-11-22 13:47:05 +01:00
pbs-config api types/config: add sync-push config type for push sync jobs 2024-11-21 10:14:53 +01:00
pbs-datastore client/server: use dedicated api type for all archive names 2024-11-22 13:47:05 +01:00
pbs-fuse-loop fuse-loop: remove lazy_static dependency 2024-08-14 12:08:01 +02:00
pbs-key-config move pbs_config::key_config to pbs-key-config 2022-12-12 14:19:52 +01:00
pbs-pxar-fuse use XATTR_* constants instead of calling functions 2024-06-20 11:08:58 +02:00
pbs-tape tape: fix read element status for some changers 2024-09-03 09:22:08 +02:00
pbs-tools tools: remove unused dependencies 2024-08-14 12:13:50 +02:00
proxmox-backup-banner switch regular dependencies to workspace ones 2022-12-12 09:07:12 +01:00
proxmox-backup-client client/server: use dedicated api type for all archive names 2024-11-22 13:47:05 +01:00
proxmox-file-restore client/server: use dedicated api type for all archive names 2024-11-22 13:47:05 +01:00
proxmox-restore-daemon api: replace deprecated 'streaming' attribute with 'serializing' 2024-09-05 14:01:45 +02:00
pxar-bin client: tools: make tools module public 2024-10-23 16:10:41 +02:00
src client/server: use dedicated api type for all archive names 2024-11-22 13:47:05 +01:00
templates server: notifications: send tape notifications via notification system 2024-04-23 23:14:46 +02:00
tests client/server: use dedicated api type for all archive names 2024-11-22 13:47:05 +01:00
www ui: sync view: set proxy on view instead of model 2024-11-21 10:14:53 +01:00
zsh-completions zsh: fix completions 2021-09-03 10:29:48 +02:00
.gitignore gitignore: generally ignore generated systemd service files 2024-03-08 08:00:30 +01:00
Cargo.toml bump version to 3.2.11-1 2024-11-21 12:47:11 +01:00
defines.mk docs: add datastore.cfg.5 man page 2021-02-10 11:05:02 +01:00
Makefile make: add deb-nostrip target 2024-06-28 13:52:52 +02:00
README.rst update README.rst to refer to .cargo/config.toml 2024-06-20 12:31:18 +02:00
rustfmt.toml bump edition in rustfmt.toml 2022-10-13 15:01:11 +02:00
TODO.rst tape: add/use rust scsi changer implementation using libsgutil2 2021-01-25 13:14:07 +01:00

Build & Release Notes
*********************

``rustup`` Toolchain
====================

We normally want to build with the ``rustc`` Debian package. To do that
you can set the following ``rustup`` configuration:

    # rustup toolchain link system /usr
    # rustup default system


Versioning of proxmox helper crates
===================================

To use current git master code of the proxmox* helper crates, add::

   git = "git://git.proxmox.com/git/proxmox"

or::

   path = "../proxmox/proxmox"

to the proxmox dependency, and update the version to reflect the current,
pre-release version number (e.g., "0.1.1-dev.1" instead of "0.1.0").


Local cargo config
==================

This repository ships with a ``.cargo/config.toml`` that replaces the crates.io
registry with packaged crates located in ``/usr/share/cargo/registry``.

A similar config is also applied building with dh_cargo. Cargo.lock needs to be
deleted when switching between packaged crates and crates.io, since the
checksums are not compatible.

To reference new dependencies (or updated versions) that are not yet packaged,
the dependency needs to point directly to a path or git source (e.g., see
example for proxmox crate above).


Build
=====
on Debian 12 Bookworm

Setup:
  1. # echo 'deb http://download.proxmox.com/debian/devel/ bookworm main' | sudo tee /etc/apt/sources.list.d/proxmox-devel.list
  2. # sudo wget https://enterprise.proxmox.com/debian/proxmox-release-bookworm.gpg -O /etc/apt/trusted.gpg.d/proxmox-release-bookworm.gpg
  3. # sudo apt update
  4. # sudo apt install devscripts debcargo clang
  5. # git clone git://git.proxmox.com/git/proxmox-backup.git
  6. # cd proxmox-backup; sudo mk-build-deps -ir

Note: 2. may be skipped if you already added the PVE or PBS package repository

You are now able to build using the Makefile or cargo itself, e.g.::

  # make deb
  # # or for a non-package build
  # cargo build --all --release

Design Notes
************

Here are some random thought about the software design (unless I find a better place).


Large chunk sizes
=================

It is important to notice that large chunk sizes are crucial for performance.
We have a multi-user system, where different people can do different operations
on a datastore at the same time, and most operation involves reading a series
of chunks.

So what is the maximal theoretical speed we can get when reading a series of
chunks? Reading a chunk sequence need the following steps:

- seek to the first chunk's start location
- read the chunk data
- seek to the next chunk's start location
- read the chunk data
- ...

Lets use the following disk performance metrics:

:AST: Average Seek Time (second)
:MRS: Maximum sequential Read Speed (bytes/second)
:ACS: Average Chunk Size (bytes)

The maximum performance you can get is::

  MAX(ACS) = ACS /(AST + ACS/MRS)

Please note that chunk data is likely to be sequential arranged on disk, but
this it is sort of a best case assumption.

For a typical rotational disk, we assume the following values::

  AST: 10ms
  MRS: 170MB/s

  MAX(4MB)  = 115.37 MB/s
  MAX(1MB)  =  61.85 MB/s;
  MAX(64KB) =   6.02 MB/s;
  MAX(4KB)  =   0.39 MB/s;
  MAX(1KB)  =   0.10 MB/s;

Modern SSD are much faster, lets assume the following::

  max IOPS: 20000 => AST = 0.00005
  MRS: 500Mb/s

  MAX(4MB)  = 474 MB/s
  MAX(1MB)  = 465 MB/s;
  MAX(64KB) = 354 MB/s;
  MAX(4KB)  =  67 MB/s;
  MAX(1KB)  =  18 MB/s;


Also, the average chunk directly relates to the number of chunks produced by
a backup::

  CHUNK_COUNT = BACKUP_SIZE / ACS

Here are some staticics from my developer worstation::

  Disk Usage:       65 GB
  Directories:   58971
  Files:        726314
  Files < 64KB: 617541

As you see, there are really many small files. If we would do file
level deduplication, i.e. generate one chunk per file, we end up with
more than 700000 chunks.

Instead, our current algorithm only produce large chunks with an
average chunks size of 4MB. With above data, this produce about 15000
chunks (factor 50 less chunks).