5
0
mirror of git://git.proxmox.com/git/proxmox-backup.git synced 2025-01-03 01:18:02 +03:00
proxmox-backup/pbs-client/src
Christian Ebner c57ac02879 pxar: client: fix missing file size check for metadata comparison
Change detection mode set to metadata compares regular file entries
metadata to the reference metadata archive of the previous run. The
`pxar::format::Stat` as stored in `pxar::Metadata` however does not
include the actual file size, it only partially stores information
gathered from stating the file.

This means however that the actual file size is never compared and
therefore, that if the file size did change, but the other metadata
information did not (including the mtime which might have been
restored), that file will be incorrectly reused.
A subsequent restore will however fail, because the expected file size
as encoded in the metadata archive does not match the file size as
stored in the payload archive.

Fix this by adding the missing file size check, comparing the size
for the given file against the one stored in the metadata archive.

Link to issue reported in community forum:
https://forum.proxmox.com/threads/158722/

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2024-12-09 09:43:49 +01:00
..
pxar pxar: client: fix missing file size check for metadata comparison 2024-12-09 09:43:49 +01:00
tools pbs-client: remove log dependency and migrate to tracing 2024-12-05 08:31:52 +01:00
backup_reader.rs client/server: use dedicated api type for all archive names 2024-11-22 13:47:05 +01:00
backup_repo.rs tree-wide: bump edition to 2021 2022-12-06 13:31:01 +01:00
backup_specification.rs client: backup spec: rename change detection mode default 2024-06-10 10:30:05 +02:00
backup_stats.rs client: backup writer: refactor backup and upload stats counters 2024-11-21 10:14:53 +01:00
backup_writer.rs pbs-client: remove log dependency and migrate to tracing 2024-12-05 08:31:52 +01:00
catalog_shell.rs pbs-client: remove log dependency and migrate to tracing 2024-12-05 08:31:52 +01:00
chunk_stream.rs client: chunk stream: switch payload stream chunker 2024-06-05 16:39:42 +02:00
http_client.rs pbs-client: remove log dependency and migrate to tracing 2024-12-05 08:31:52 +01:00
inject_reused_chunks.rs client: backup writer: refactor backup and upload stats counters 2024-11-21 10:14:53 +01:00
lib.rs client: backup writer: allow push uploading index and chunks 2024-11-21 10:14:53 +01:00
merge_known_chunks.rs cargo: switch from proc-macro pin-project to declarative pin-project-lite 2021-09-22 11:15:40 +02:00
pipe_to_stream.rs clippy 1.65 fixes 2022-12-05 11:40:02 +01:00
pxar_backup_stream.rs pbs-client: remove log dependency and migrate to tracing 2024-12-05 08:31:52 +01:00
remote_chunk_reader.rs blob/chunk parse errors: add context 2023-08-08 13:57:04 +02:00
task_log.rs pbs-client: remove log dependency and migrate to tracing 2024-12-05 08:31:52 +01:00
vsock_client.rs move json_object_to_query to proxmox-http+http-helpers 2022-07-04 10:08:53 +02:00