refactor info/link extraction from onlinehelp to utils

so that we can reuse that code for getting links from the docs

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2019-06-21 12:03:49 +02:00 committed by Thomas Lamprecht
parent 9a8c1d01b6
commit 1098bee4d4
2 changed files with 25 additions and 19 deletions

View File

@ -593,6 +593,29 @@ Ext.define('Proxmox.Utils', { utilities: {
return Ext.Date.format(servertime, 'Y-m-d H:i:s');
},
get_help_info: function(section) {
var helpMap;
if (typeof proxmoxOnlineHelpInfo !== 'undefined') {
helpMap = proxmoxOnlineHelpInfo;
} else if (typeof pveOnlineHelpInfo !== 'undefined') {
// be backward compatible with older pve-doc-generators
helpMap = pveOnlineHelpInfo;
} else {
throw "no global OnlineHelpInfo map declared";
}
return helpMap[section];
},
get_help_link: function(section) {
var info = Proxmox.Utils.get_help_info(section);
if (!info) {
return;
}
return window.location.origin + info.link;
},
openXtermJsViewer: function(vmtype, vmid, nodename, vmname, cmd) {
var url = Ext.Object.toQueryString({
console: vmtype, // kvm, lxc, upgrade or shell

View File

@ -41,25 +41,11 @@ Ext.define('Proxmox.button.Help', {
}
},
getOnlineHelpInfo: function (ref) {
var helpMap;
if (typeof proxmoxOnlineHelpInfo !== 'undefined') {
helpMap = proxmoxOnlineHelpInfo;
} else if (typeof pveOnlineHelpInfo !== 'undefined') {
// be backward compatible with older pve-doc-generators
helpMap = pveOnlineHelpInfo;
} else {
throw "no global OnlineHelpInfo map declared";
}
return helpMap[ref];
},
// this sets the link and the tooltip text
setOnlineHelp:function(blockid) {
var me = this;
var info = me.getOnlineHelpInfo(blockid);
var info = Proxmox.Utils.get_help_info(blockid);
if (info) {
me.onlineHelp = blockid;
var title = info.title;
@ -81,10 +67,7 @@ Ext.define('Proxmox.button.Help', {
var docsURI;
if (me.onlineHelp) {
var info = me.getOnlineHelpInfo(me.onlineHelp);
if (info) {
docsURI = window.location.origin + info.link;
}
docsURI = Proxmox.Utils.get_help_link(me.onlineHelp);
}
if (docsURI) {