Proxmox/proxmox-widget-toolkit
5
0
Fork 0
Code Pull Requests Releases Activity

data/*Store: drop storeid requirement

Browse Source 
We never use that and it serves no purpose. It probably was meant to
be the upstream config 'storeId' which would add the store to the
Ext.StoreManager. This is unpractical though, since then the store
has to be explicitely destroyed, otherwise the StoreManager retains a
reference and the GC cannot remove the store.

Since donwstream users of the store can simply give the 'storeId'
property anyway if they need to be managed by the StoreManager, drop
the requirement here.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Dominik Csapak 2021-03-11 10:14:32 +01:00 committed by Thomas Lamprecht
parent 3f81450686
commit 6732337cb9
3 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/data/ObjectStore.js
View File

@ -21,10 +21,6 @@ Ext.define('Proxmox.data.ObjectStore', {
config = config || {};
if (!config.storeid) {
config.storeid = 'proxmox-store-' + ++Ext.idSeed;
}
Ext.applyIf(config, {
model: 'KeyValue',
proxy: {

5
src/data/RRDStore.js
View File

@ -37,11 +37,6 @@ Ext.define('Proxmox.data.RRDStore', {
config.interval = 30000;
}
// set a new storeid
if (!config.storeid) {
config.storeid = 'rrdstore-' + ++Ext.idSeed;
}
// rrdurl is required
if (!config.rrdurl) {
throw "no rrdurl specified";

3
src/data/UpdateStore.js
View File

@ -33,9 +33,6 @@ Ext.define('Proxmox.data.UpdateStore', {
delete config.interval;
}
if (!config.storeid) {
throw "no storeid specified";
}
let load_task = new Ext.util.DelayedTask();