Proxmox/proxmox
5
0
Fork 1
Code Issues Pull Requests Releases Activity
2,972 Commits 3 Branches 0 Tags 16 MiB
6158d53697
Commit Graph

77 Commits

Author SHA1 Message Date
Wolfgang Bumiller
0177b1d975 add proxmox-rrd-api-types crate - moved out of proxmox-rrd 
so we can access them from wasm without pulling in proxmox-rrd as it
also pulls in sys...

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2024-09-18 15:55:43 +02:00
Lukas Wagner
9426af0abf rrd: derive Display and FromStr for api types 
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
 2024-09-18 15:21:58 +02:00
Maximiliano Sandoval
b7100ecc1e rrd_map: remove unnecessary use of get().is_some() 
Fixes:

warning: unnecessary use of `get(rel_path).is_some()`
   --> proxmox-rrd/src/cache/rrd_map.rs:107:21
    |
107 |         if self.map.get(rel_path).is_some() {
    |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(rel_path)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
 2024-08-28 13:09:15 +02:00
Maximiliano Sandoval
5586eeaba8 rrd_map: remove unneded return statement 
Fixes:

warning: unneeded `return` statement
   --> proxmox-rrd/src/cache/rrd_map.rs:117:13
    |
117 |             return Ok(true);
    |             ^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
117 -             return Ok(true);
117 +             Ok(true)
    |

warning: unneeded `return` statement
   --> proxmox-rrd/src/cache/rrd_map.rs:119:13
    |
119 |             return Ok(false);
    |             ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
119 -             return Ok(false);
119 +             Ok(false)

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
 2024-08-28 13:09:15 +02:00
Wolfgang Bumiller
93d42ad488 rrd: rustfmt and style fix 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2024-08-09 11:20:15 +02:00
Lukas Wagner
88731c52f0 rrd: add api-types 
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
 2024-08-09 11:01:30 +02:00
Lukas Wagner
7ea63a6fb9 rrd: try to load database if not already present in cache 
Before, a call to `update` was necessary to load an existing database
into the cache. If `update` was never called, `extract_cached_data`
would simply return no data.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
 2024-08-09 11:01:30 +02:00
Lukas Wagner
f01c1e0ce9 rrd: cache: add update_value_ignore_old 
This function is the same as the regular `update_value`, but it
sets the `new_only` flag when updating the value in the rrd map.
This avoids "time in past" messages being logged in case a data point
happens to be added twice. This new function will just silently reject
values that have an older timestamp than the most recent one.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
 2024-08-09 11:01:30 +02:00
Lukas Wagner
4ca2e01442 rrd: deprecate create_pbs_default_rrd 
This one should be in the client code.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
 2024-08-09 11:01:30 +02:00
Maximiliano Sandoval
254a37ae07 fix typos in code documentation 
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
 2024-07-22 08:49:42 +02:00
Wolfgang Bumiller
0652d81977 tree-wide: enable doc_cfg and doc_auto_cfg for docs 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2024-07-02 11:59:53 +02:00
Wolfgang Bumiller
533954ed38 bump bitflags dependency to 2.4 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2024-06-20 13:48:32 +02:00
Fabian Grünbichler
6f532dfb7d various clippy fixes 
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2024-06-06 11:40:49 +02:00
Lukas Wagner
2f94283367 rrd: spell out hard to understand abbreviations in public types 
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
 2024-02-01 10:32:19 +01:00
Lukas Wagner
f9e8ebfdc8 rrd: fix a few typos 
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
 2024-02-01 10:32:19 +01:00
Lukas Wagner
6eed8ed992 rrd: feature-gate support for the v1 format 
new users of this crate might not really need support for the v1
format.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
 2024-02-01 10:32:19 +01:00
Thomas Lamprecht
109902fbf0 tree-wide: fix various typos 
found with codespell

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2023-11-29 18:32:07 +01:00
Fabian Grünbichler
1aa6f0ea22 clippy 1.65 fixes 
and rustfmt

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2022-12-05 11:40:02 +01:00
Wolfgang Bumiller
3193237afd rrd: add Entry::get() to access the data 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2022-11-24 13:53:49 +01:00
Wolfgang Bumiller
56b5c28930 rrd: Entry type and clippy fixes 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2022-07-27 14:54:44 +02:00
Thomas Lamprecht
d845736270 tree wide: typo fixes through codespell 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2022-06-07 14:08:09 +02:00
Thomas Lamprecht
d5b9d1f482 rrd: rust fmt 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2022-04-06 16:56:33 +02:00
Thomas Lamprecht
43b602248d rrd: extract data: avoid always calculating start-time fallback 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2022-02-15 07:59:55 +01:00
Thomas Lamprecht
5740f36ef8 rrd: avoid intermediate index, directly loop over data 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2022-02-15 07:59:55 +01:00
Thomas Lamprecht
6149c171ca rrd cache: code style, avoid useless intermediate mutable 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2022-02-15 07:59:12 +01:00
Fabian Grünbichler
d80d195c26 misc clippy fixes 
the trivial ones ;)

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2022-02-08 14:57:16 +01:00
Fabian Grünbichler
c8e73a225a rrd: drop redundant field names 
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2021-12-30 15:02:07 +01:00
Fabian Grünbichler
872b5f41cd tree-wide: drop redundant clones 
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2021-12-30 15:02:07 +01:00
Fabian Grünbichler
5b19368000 tree-wide: fix needless borrows 
found and fixed via clippy

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2021-12-30 13:55:33 +01:00
Dietmar Maurer
a092ef9c32 update to proxmox-sys 0.2 crate 
- imported pbs-api-types/src/common_regex.rs from old proxmox crate
- use hex crate to generate/parse hex digest
- remove all reference to proxmox crate (use proxmox-sys and
  proxmox-serde instead)

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
 2021-11-24 10:32:27 +01:00
Dominik Csapak
8e344d3d67 rrd: use saturating_sub to avoid underflow 
Without this, the tests fail in debug mode.
Also having start (u64) underflow to a value greater than end does
not really make sense

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2021-10-28 12:54:54 +02:00
Dietmar Maurer
75ca726c29 use new fsync parameter to replace_file and atomic_open_or_create 
Depend on proxmox 0.15.0 and proxmox-openid 0.8.1

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
 2021-10-21 07:28:32 +02:00
Dietmar Maurer
412712029c proxmox-rrd: use fsync instead of syncfs 
syncfs can sync unrelated data, and we do not want that.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
 2021-10-20 11:46:59 +02:00
Dietmar Maurer
86b50e18ed proxmox-rrd: improve dev docs 
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
 2021-10-19 11:17:09 +02:00
Dietmar Maurer
ed6a7f52e5 proxmox-rrd: cleanup - impl FromStr for JournalEntry 
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
 2021-10-19 11:17:09 +02:00
Dietmar Maurer
75bb60e7b3 proxmox-rrd: add option to avoid page cache for load/save 
use fadvice(.., POSIX_FADV_DONTNEED) for RRD files. We read those files only once,
and always rewrite them.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
 2021-10-19 11:17:09 +02:00
Dietmar Maurer
336e8f3e7f proxmox-rrd: use syncfs after writing rrd files 
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
 2021-10-19 11:17:09 +02:00
Dietmar Maurer
77c2e4668b proxmox-rrd: use fine grained locking in commit_journal_impl 
Aquire the rrd_map lock for each file (else we block access for a long time)
 2021-10-18 14:55:47 +02:00
Dietmar Maurer
cc0bb59788 proxmox-rrd: log all errors from apply_and_commit_journal_thread (but only once) 2021-10-18 11:57:19 +02:00
Dietmar Maurer
e23f3ec774 proxmox-rrd: cleanup list_old_journals 2021-10-18 10:00:58 +02:00
Dietmar Maurer
a74384f725 proxmox-rrd: cleanup - use struct instead of tuple 2021-10-16 12:45:03 +02:00
Dietmar Maurer
4393b93a8b proxmox-rrd: move RRDMap into extra file 2021-10-16 12:45:03 +02:00
Dietmar Maurer
9dcc64b71a proxmox-rrd: move JournalState into extra file 2021-10-16 12:45:03 +02:00
Dietmar Maurer
30b4800f4f proxmox-rrd: implement non blocking journal 
Do not block while applying the journal.
 2021-10-16 12:45:03 +02:00
Dietmar Maurer
2c24c1dd22 proxmox-rrd: rename RRDCacheState to JournalState 2021-10-15 09:35:44 +02:00
Dietmar Maurer
2be07c2250 proxmox-rrd: avoild blocking readers while applying the journal 
By using and extra RwLock<RRDMap> on the rrd data.
 2021-10-15 09:22:07 +02:00
Dietmar Maurer
3275f1ac16 proxmox-rrd: log journal apply/flush times, split apply and flush 
We need to apply the journal only once.
 2021-10-15 07:16:41 +02:00
Dietmar Maurer
ec5d84f4d3 proxmox-rrd: cleanup - use slot_end_time() 2021-10-14 16:29:00 +02:00
Dietmar Maurer
2b9fb32de1 proxmox-rrd: cleanup - use staturating_add instead of if/else 2021-10-14 16:10:55 +02:00
Dietmar Maurer
26bd6a4f77 proxmox-rrd: improve dev docs 2021-10-14 11:53:54 +02:00