Go to file
Max Carrara 1f351625a5 async: runtime: Modernise module and update docs
This commit updates all helper functions, taking into account recent
developments regarding `tokio`.

In particular, the `block_in_place()` and `block_on()` functions now
don't panic anymore if used within the single-threaded `tokio` runtime
and instead behave as expected in both runtime flavours.

Furthermore, because `tokio` may add more runtime flavours in the
future, all helpers will now panic if used within an unsupported
runtime. This is to prevent unforeseen behavioural quirks and
interactions with `tokio` internals.

The above changes make `BlockingGuard` redundant; it is consequently
removed.

The documentation is also updated, describing the behaviour of the
helper functions and the purpose of the `runtime.rs` module in more
detail.

Signed-off-by: Max Carrara <m.carrara@proxmox.com>
2023-08-23 09:51:52 +02:00
.cargo cargo: switch to use packaged crates by default 2020-01-03 09:39:52 +01:00
proxmox-api-macro clippy fix: this (Default) impl can be derived 2023-08-08 11:29:36 +02:00
proxmox-apt bump proxmox-apt to 0.10.5-1 2023-08-08 14:05:51 +02:00
proxmox-async async: runtime: Modernise module and update docs 2023-08-23 09:51:52 +02:00
proxmox-auth-api bump proxmox-auth-api to 0.3.1 2023-07-24 11:03:49 +02:00
proxmox-borrow update d/copyright files to debian copyright-format 1.0 2023-05-23 13:02:39 +02:00
proxmox-client client/login: clippy fixes 2023-08-22 10:04:16 +02:00
proxmox-compression bump proxmox-compression to 0.2.1-1 2023-06-15 11:01:19 +02:00
proxmox-http bump proxmox-http to 0.9.0-1 2023-05-23 13:02:51 +02:00
proxmox-http-error more import cleanups 2023-07-28 11:47:39 +02:00
proxmox-human-byte bump proxmox-human-byte to 0.1.1-1 2023-07-24 10:53:44 +02:00
proxmox-io proxmox-io: fix sparse_copy not copying sparsely on irregular read operations 2023-08-09 12:48:04 +02:00
proxmox-lang update d/copyright files to debian copyright-format 1.0 2023-05-23 13:02:39 +02:00
proxmox-ldap bump proxmox-ldap to 0.2.1-1 2023-08-08 14:09:19 +02:00
proxmox-login client/login: clippy fixes 2023-08-22 10:04:16 +02:00
proxmox-metrics bump proxmox-metrics to 0.3.0-1 2023-05-23 13:02:51 +02:00
proxmox-notify bump proxmox-notify to 0.2.0 2023-07-28 11:56:56 +02:00
proxmox-openid clippy fix: unnecessary use of to_string 2023-08-08 11:29:36 +02:00
proxmox-rest-server clippy fix: deref on an immutable reference 2023-08-08 11:29:36 +02:00
proxmox-router bump proxmox-router to 2.1.0-1 2023-07-28 11:26:01 +02:00
proxmox-schema clippy fix: complex type definitions 2023-08-08 11:29:36 +02:00
proxmox-section-config bump proxmox-section-config to 2.0.0-1 2023-07-24 11:03:15 +02:00
proxmox-serde clippy fix: the borrowed expression implements the required traits 2023-08-08 11:05:20 +02:00
proxmox-shared-memory bump proxmox-shared-memory to 0.3.0-1 2023-05-23 13:02:51 +02:00
proxmox-sortable-macro update d/copyright files to debian copyright-format 1.0 2023-05-23 13:02:39 +02:00
proxmox-subscription clippy fix: this (Default) impl can be derived 2023-08-08 11:29:36 +02:00
proxmox-sys cargo fmt 2023-06-23 11:50:39 +02:00
proxmox-tfa clippy fix: needless borrow 2023-08-08 11:29:36 +02:00
proxmox-time clippy fix: casting to the same type is unnecessary 2023-08-08 11:48:01 +02:00
proxmox-uuid update d/copyright files to debian copyright-format 1.0 2023-05-23 13:02:39 +02:00
.gitignore git: ignore top level *-deb make target files 2022-08-26 12:18:44 +02:00
build.sh build.sh: split overly long line 2023-06-03 16:48:10 +02:00
bump.sh add bump.sh 2022-12-07 10:36:27 +01:00
Cargo.toml bump proxmox-api-macro to 1.0.5-1 2023-08-03 08:25:13 +02:00
Makefile buildsys: also cleanup *.build files for convenience 2023-06-04 18:27:46 +02:00
README.rst update README 2023-08-01 15:48:19 +02:00
rustfmt.toml bump edition in rustfmt.toml 2022-10-13 15:00:28 +02:00

Local cargo config
==================

This repository ships with a ``.cargo/config`` that replaces the crates.io
registry with packaged crates located in ``/usr/share/cargo/registry``.

A similar config is also applied building with dh_cargo. Cargo.lock needs to be
deleted when switching between packaged crates and crates.io, since the
checksums are not compatible.

To reference new dependencies (or updated versions) that are not yet packaged,
the dependency needs to point directly to a path or git source.

Steps for Releases
==================

- Run ./bump.sh <CRATE> [patch|minor|major|<VERSION>]
-- Fill out changelog
-- Confirm bump commit
- Build packages with `make deb`.
-- Don't forget to commit updated d/control!

Adding Crates
=============

1) At the top level:
  - Generate the crate: ``cargo new --lib the-name``
  - Sort the crate into ``Cargo.toml``'s ``workspace.members``

2) In the new crate's ``Cargo.toml``:
  - In ``[package]`` set:
      authors.workspace = true
      license.workspace = true
      edition.workspace = true
      exclude.workspace = true
      repository.workspace = true
  - Add a meaningful ``description``
  - Copy ``debian/copyright`` and ``debian/debcargo.toml`` from another subcrate.

Adding a new Dependency
=======================

1) At the top level:
  - Add it to ``[workspace.dependencies]`` specifying the version and any
    features that should be enabled throughout the workspace

2) In each member's ``Cargo.toml``:
  - Add it to the desired dependencies section with ``workspace = true`` and no
    version specified.
  - If this member requires additional features, add only the extra features to
    the member dependency.

Updating a Dependency's Version
===============================

1) At the top level:
  - Bump the version in ``[workspace.dependencies]`` as desired.
  - Check for deprecations or breakage throughout the workspace.

Notes on Workspace Inheritance
==============================

Common metadata (like authors, license, ..) are inherited throughout the
workspace. If new fields are added that are identical for all crates, they
should be defined in the top-level ``Cargo.toml`` file's
``[workspace.package]`` section, and inherited in all members explicitly by
setting ``FIELD.workspace = true`` in the member's ``[package]`` section.

Dependency information is also inherited throughout the workspace, allowing a
single dependency specification in the top-level Cargo.toml file to be used by
all members.

Some restrictions apply:
- features can only be added in members, never removed (this includes
  ``default_features = false``!)
 - the base feature set at the workspace level should be the minimum (possibly
   empty!) set required by all members
- workspace dependency specifications cannot include ``optional``
 - if needed, the ``optional`` flag needs to be set at the member level when
   using a workspace dependency