Dominik Csapak af46b655d4 compression: zip_directory: improve error handling ... when zipping a directory, our intention was to skip over files that cannot be zipped (e.g. the file can't be read/vanished/etc.), so we ignored errors and simply logged it. but when 'add_entry' fails, we will never actually restore, since every error there is fatal to the point that the zip cannot be finished thats because we take the 'target' sink out of self, and only insert it again after all writes succeeded. so if an error occurs in between 'target' is not put into self again (and never will be) and the zip cannot be finished (even if we would catch all those intermediate errors and restore 'target', we don't know in which state the output was, so we're unable to finish a valid zip) to fix that, split the actual 'add_entry' part there out of the async move block and treat its errors always as fatal without this, we generate heaps of log lines even after an error occurred, and can never recover Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>		2023-06-15 10:28:50 +02:00
..
debian	bump proxmox-compression to 0.2.0-1	2023-05-23 13:02:51 +02:00
src	compression: zip_directory: improve error handling	2023-06-15 10:28:50 +02:00
Cargo.toml	bump proxmox-compression to 0.2.0-1	2023-05-23 13:02:51 +02:00