Proxmox/pve-apiclient
5
0
Fork 0
mirror of git://git.proxmox.com/git/pve-apiclient.git synced 2024-12-22 17:34:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

cleanup Net::SSLeay error handling

Browse Source 
X509_get_fingerprint does not die - it only returns undef in case of
errors (or segfaults if the $cert pointer is invalid).
This commit is contained in:
Fabian Grünbichler 2017-11-27 10:18:48 +01:00
parent adbda0b73e
commit 1d40f3c38c
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
PVE/APIClient/LWP.pm
View File

@ -258,11 +258,8 @@ my $verify_cert_callback = sub {
# check server certificate against cache of pinned FPs
# get fingerprint of server certificate
my $fp;
eval {
$fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
};
return 0 if $@ || !defined($fp) || $fp eq ''; # error
my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
return 0 !defined($fp) || $fp eq ''; # error
my $valid = $self->{cached_fingerprints}->{$fp};
return $valid if defined($valid); # return cached result