From 2937fdf9839567c5692ac45d3c1704ddfe878de4 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 19 May 2023 15:36:44 +0200 Subject: [PATCH] remove Exception update targets, just comment how it's very odd to have buildsystem targets that go over the git repos root directory boundary, as one *must not* depend on unrelated things. Rather just comment that and how this was derived from pve-common's exception module. Signed-off-by: Thomas Lamprecht --- Makefile | 7 ------- PVE/APIClient/Exception.pm | 3 +++ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index da41510..0125f2a 100644 --- a/Makefile +++ b/Makefile @@ -11,9 +11,6 @@ DESTDIR= PERL5DIR=$(DESTDIR)/usr/share/perl5 DOCDIR=$(DESTDIR)/usr/share/doc/$(PACKAGE) -PVE_COMMON_FILES= \ - Exception.pm - GITVERSION:=$(shell git rev-parse HEAD) all: $(DEB) @@ -43,10 +40,6 @@ install: install -m 0755 examples/example2.pl $(DOCDIR)/examples install -m 0755 examples/perftest1.pl $(DOCDIR)/examples -update-pve-common: - for i in $(PVE_COMMON_FILES); do cp ../pve-common/src/PVE/$$i PVE/APIClient/; done - for i in $(PVE_COMMON_FILES); do sed -i 's/PVE::/PVE::APIClient::/g' PVE/APIClient/$$i; done - .PHONY: upload upload: $(DEB) tar cf - $(DEB) | ssh -X repoman@repo.proxmox.com upload --product pmg,pve --dist bullseye diff --git a/PVE/APIClient/Exception.pm b/PVE/APIClient/Exception.pm index c7c78c0..e9110f1 100644 --- a/PVE/APIClient/Exception.pm +++ b/PVE/APIClient/Exception.pm @@ -1,5 +1,8 @@ package PVE::APIClient::Exception; +# NOTE: derived from pve-common's PVE::Execption by copying and then: +# sed -i 's/PVE::/PVE::APIClient::/g' Exception.pm + # a way to add more information to exceptions (see man perlfunc (die)) # use PVE::APIClient::Exception qw(raise); # raise ("my error message", code => 400, errors => { param1 => "err1", ...} );