mirror of
git://git.proxmox.com/git/pve-apiclient.git
synced 2024-12-22 17:34:22 +03:00
avoid harmful '<>' pattern, explicitly read from STDIN
Fixes problems in CLIHandler using the code pattern: while (my $line = <>) { ... } For why this causes only _now_ problems lets first look how <> behaves: "The null filehandle <> is special: [...] Input from <> comes either from standard input, or from each file listed on the command line. Here's how it works: the first time <> is evaluated, the @ARGV array is checked, and if it is empty, $ARGV[0] is set to "-" , which when opened gives you standard input. The @ARGV array is then processed as a list of filenames." - 'perldoc perlop' Recent changes in the CLIHandler code changed how we modfiied @ARGV Earlier we assumed that the first argument must be the command and thus shifted it out of @ARGV, now we can have multiple levels of (sub)commands. This change also changed how we handle @ARGV, we do not unshift anything but go through the arguments until we got to the final command and copy the rest of @ARGV as we know that this must be the commandos arguments. For '<>' this means that ARGV was still fully populated and perl tried to open element as a file, which naturally failed. Thus the change in pve-common only exposed this 'dangerous' code pattern. Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
parent
3c43d96ef9
commit
ff8ba9c9d9
@ -146,7 +146,7 @@ sub manual_verify_fingerprint {
|
||||
"X509 SHA256 key fingerprint is $fingerprint.\n" .
|
||||
"Are you sure you want to continue connecting (yes/no)? ";
|
||||
|
||||
my $answer = <>;
|
||||
my $answer = <STDIN>;
|
||||
|
||||
my $valid = ($answer =~ m/^\s*yes\s*$/i) ? 1 : 0;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user