Proxmox/pve-firewall
5
0
Fork 0
mirror of git://git.proxmox.com/git/pve-firewall.git synced 2025-01-24 06:03:55 +03:00
Code Releases Activity

remove redundant checks

Browse Source
This commit is contained in:
Wolfgang Bumiller 2016-10-05 15:36:54 +02:00 committed by Dietmar Maurer
parent 2ea28d0c01
commit 95e3594912
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/PVE/Firewall.pm
View File

@ -1831,8 +1831,8 @@ sub ruleset_generate_cmdstr {
}
}
if ($rule->{proto}) {
push @cmd, "-p $rule->{proto}";
if (my $proto = $rule->{proto}) {
push @cmd, "-p $proto";
my $multiport = 0;
$multiport++ if $nbdport > 1;
@ -1844,12 +1844,12 @@ sub ruleset_generate_cmdstr {
if ($multiport == 2) && ($rule->{dport} ne $rule->{sport});
if ($rule->{dport}) {
if ($rule->{proto} && $rule->{proto} eq 'icmp') {
if ($proto eq 'icmp') {
# Note: we use dport to store --icmp-type
die "unknown icmp-type '$rule->{dport}'\n"
if $rule->{dport} !~ /^\d+$/ && !defined($icmp_type_names->{$rule->{dport}});
push @cmd, "-m icmp --icmp-type $rule->{dport}";
} elsif ($rule->{proto} && $rule->{proto} eq 'icmpv6') {
} elsif ($proto eq 'icmpv6') {
# Note: we use dport to store --icmpv6-type
die "unknown icmpv6-type '$rule->{dport}'\n"
if $rule->{dport} !~ /^\d+$/ && !defined($icmpv6_type_names->{$rule->{dport}});