Proxmox/pve-firewall
5
0
Fork 0
mirror of git://git.proxmox.com/git/pve-firewall.git synced 2025-01-09 01:18:04 +03:00
Code Releases Activity

log errors encountered by the daemon to syslog

Browse Source
This commit is contained in:
Wolfgang Bumiller 2017-03-22 12:53:34 +01:00 committed by Fabian Grünbichler
parent 55b473712e
commit eedcb56462
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/PVE/Firewall.pm
View File

@ -13,6 +13,7 @@ use PVE::Cluster;
use PVE::ProcFSTools;
use PVE::Tools qw($IPV4RE $IPV6RE);
use PVE::Network;
use PVE::SafeSyslog;
use File::Basename;
use File::Path;
use IO::File;
@ -2506,10 +2507,14 @@ sub parse_fw_rule {
die "unable to parse rule parameters: $line\n" if length($line);
$rule = verify_rule($rule, $cluster_conf, $fw_conf, $rule_env, 1);
if ($verbose && $rule->{errors}) {
warn "$prefix - errors in rule parameters: $orig_line\n";
if ($rule->{errors}) {
# The verbose flag really means we're running from the CLI and want
# output on the console - in the other case we really want such errors
# to go into the syslog instead.
my $log = $verbose ? sub { warn @_ } : sub { syslog(err => @_) };
$log->("$prefix - errors in rule parameters: $orig_line\n");
foreach my $p (keys %{$rule->{errors}}) {
warn " $p: $rule->{errors}->{$p}\n";
$log->(" $p: $rule->{errors}->{$p}\n");
}
}