Proxmox/pve-guest-common
5
0
Fork 0
mirror of git://git.proxmox.com/git/pve-guest-common.git synced 2024-12-23 17:34:10 +03:00
Code Releases Activity

fix #1291: implement remove_vmid_from_backup_jobs

Browse Source 
remove_vmid_from_backup_jobs updates the vzdump.cron backup jobs,
excluding the given vmid.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
This commit is contained in:
Christian Ebner 2019-10-15 13:00:20 +02:00 committed by Thomas Lamprecht
parent e2a0a93be0
commit 8c3af92574
1 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
PVE/VZDump/Plugin.pm
View File

@ -7,6 +7,8 @@ use POSIX qw(strftime);
use PVE::Tools;
use PVE::SafeSyslog;
use PVE::Cluster qw(cfs_read_file cfs_write_file cfs_lock_file);
use PVE::VZDump::Common; # register parser/writer for vzdump.cron
my $log_level = {
err => 'ERROR:',
@ -168,4 +170,48 @@ sub cleanup {
die "internal error"; # implement in subclass
}
sub remove_vmid_from_list {
my ($list, $rm_vmid) = @_;
# this removes the given vmid from the list, if present
return join(',', grep { $_ ne $rm_vmid } PVE::Tools::split_list($list));
}
sub remove_vmid_from_jobs {
my ($jobs, $exclude_vmid) = @_;
my $updated_jobs = [];
foreach my $job (@$jobs) {
if (defined $job->{vmid}) {
my $list = remove_vmid_from_list($job->{vmid}, $exclude_vmid);
if ($list) {
$job->{vmid} = $list;
push @$updated_jobs, $job;
}
} elsif (defined $job->{exclude}) {
my $list = remove_vmid_from_list($job->{exclude}, $exclude_vmid);
if ($list) {
$job->{exclude} = $list;
} else {
delete $job->{exclude};
}
push @$updated_jobs, $job;
} else {
push @$updated_jobs, $job;
}
}
return $updated_jobs;
}
sub remove_vmid_from_backup_jobs {
my ($vmid) = @_;
cfs_lock_file('vzdump.cron', undef, sub {
my $vzdump_jobs = cfs_read_file('vzdump.cron');
my $jobs = $vzdump_jobs->{jobs} || [];
$vzdump_jobs->{jobs} = remove_vmid_from_jobs($jobs, $vmid);
cfs_write_file('vzdump.cron', $vzdump_jobs);
});
die "$@" if ($@);
}
1;