5
0
mirror of git://git.proxmox.com/git/pve-guest-common.git synced 2024-12-28 07:21:36 +03:00
Go to file
Wolfgang Link ce22af0895 fix #1694: make failure of snapshot removal non-fatal
In certain high-load scenarios ANY ZFS operation can block,
including registering an (async) destroy.
Since ZFS operations are implemented via ioctl's,
killing the user space process
does not affect the waiting kernel thread processing the ioctl.

Once "zfs destroy" has been called, killing it does not say anything
about whether the destroy operation will be aborted or not.
Since running into a timeout effectively means killing it,
we don't know whether the snapshot exists afterwards or not.
We also don't know how long it takes for ZFS to catch up on pending ioctls.

Given the above problem, we must to not die on errors when deleting a no
longer needed snapshot fails (under a timeout) after an otherwise
successful replication. Since we retry on the next run anyway, this is
not problematic.

The snapshot deletion error will be logged in the replication log
and the syslog/journal.
2018-04-16 10:40:48 +02:00
debian bump version to 2.0-14 2017-12-13 14:51:50 +01:00
PVE fix #1694: make failure of snapshot removal non-fatal 2018-04-16 10:40:48 +02:00
Makefile bump version to 2.0-14 2017-12-13 14:51:50 +01:00