Proxmox/pve-ha-manager
5
0
Fork 0
mirror of git://git.proxmox.com/git/pve-ha-manager.git synced 2025-01-31 05:47:19 +03:00
Code Releases Activity

fix #4984: manager: add service to migration-target usage only if online

Browse Source 
Otherwise, when using the 'basic' plugin, this would lead to
auto-vilification of the $target node in the Perl hash tracking the
usage and it would wrongly be considered online when selecting the
recovery node.

The 'static' plugin was not affected, because it would check and warn
before adding usage to a node that was not registered with add_node()
first. Doing the same in the 'basic' plugin will be done by another
patch.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
 [ TL: shorten commit message subject ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Fiona Ebner 2023-10-05 16:05:45 +02:00 committed by Thomas Lamprecht
parent 4cb3b2cf9b
commit c7843a315d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/PVE/HA/Manager.pm
View File

@ -275,7 +275,8 @@ sub recompute_online_node_usage {
# count it for both, source and target as load is put on both
$online_node_usage->add_service_usage_to_node($source, $sid, $source, $target)
if $state ne 'request_start_balance';
$online_node_usage->add_service_usage_to_node($target, $sid, $source, $target);
$online_node_usage->add_service_usage_to_node($target, $sid, $source, $target)
if $online_node_usage->contains_node($target);
} elsif ($state eq 'stopped' || $state eq 'request_start') {
# do nothing
} else {