Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

ui: vm/usbedit: simplify USB3 handling

Browse Source 
Enable USB3 by default. There are no restrictions anymore that the speed
of the dev must match the USB3 speed. The xhci controller can deal with
USB 2 and 1 devices. USB3 devices can be plugged in a USB2 (ehci)
controller. As discussed in [0]

When using a USB device for SPICE passthrough my tests showed that USB2
devices connecting to the xhci controller work but a USB3 device passed
via Spice cannot connect to an ehci controller (no USB3 enabled).

qemu-server 6.0-9 supports USB3 also for Spice USB passthrough. See
commit 733234b [1].

All this means we can get rid of the separate handling of USB3 and non
USB3 devices and leave the decision to the user if USB3 should be
enabled or not.

[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/039131.html
[1]: https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=733234be04d585febd74c655d8b82d17ebf9e133

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Aaron Lauterer 2019-09-26 15:03:17 +02:00 committed by Thomas Lamprecht
parent d6c2bc3074
commit 0088bfd649
1 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
www/manager6/qemu/USBEdit.js
View File

@ -9,32 +9,6 @@ Ext.define('PVE.qemu.USBInputPanel', {
data: {}
},
controller: {
xclass: 'Ext.app.ViewController',
control: {
'pveUSBSelector': {
change: function(field, newValue, oldValue) {
var usb3field = this.lookupReference('usb3');
var usbval = field.getUSBValue();
var dev_is_usb3 = /usb3=1/.test(usbval);
if (dev_is_usb3) {
usb3field.savedVal = usb3field.getValue();
usb3field.setValue(true);
} else {
if (usb3field.savedVal !== undefined) {
usb3field.setValue(usb3field.savedVal);
} else {
usb3field.setValue(usb3field.originalValue);
}
usb3field.setDisabled(false);
}
}
}
}
},
setVMConfig: function(vmconfig) {
var me = this;
me.vmconfig = vmconfig;
@ -129,6 +103,7 @@ Ext.define('PVE.qemu.USBInputPanel', {
xtype: 'checkbox',
name: 'usb3',
inputValue: true,
checked: true,
reference: 'usb3',
fieldLabel: gettext('Use USB3')
}