Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

api: backup: auto-inject job id where expected by the API

Browse Source 
for backwards compatibility. Otherwise, e.g. listing backup jobs with
pvesh get /cluster/backup is broken. And suddenly not having the
property anymore would be a breaking API change.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner 2022-11-15 11:18:29 +01:00 committed by Thomas Lamprecht
parent 16a194d89e
commit 082e029758
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
PVE/API2/Backup.pm
View File

@ -130,6 +130,10 @@ __PACKAGE__->register_method({
$job->{'next-run'} = $next_run if defined($next_run);
}
# FIXME remove in PVE 8.0?
# backwards compat: before moving the job registry to pve-common, id was auto-injected
$job->{id} = $jobid;
push @$res, $job;
}
@ -273,7 +277,12 @@ __PACKAGE__->register_method({
my $jobs_data = cfs_read_file('jobs.cfg');
my $job = $jobs_data->{ids}->{$param->{id}};
return $job if $job && $job->{type} eq 'vzdump';
if ($job && $job->{type} eq 'vzdump') {
# FIXME remove in PVE 8.0?
# backwards compat: before moving the job registry to pve-common, id was auto-injected
$job->{id} = $param->{id};
return $job;
}
raise_param_exc({ id => "No such job '$param->{id}'" });