Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

ui: hide 'no tags' field and edit icon without VM.Config.Options

Browse Source 
they cannot edit them anyway, so no point in showing them that
there is no tag

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2022-11-18 12:59:15 +01:00 committed by Thomas Lamprecht
parent 56dee217bc
commit 1b48b8b7a1
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
www/manager6/form/TagEdit.js
View File

@ -7,6 +7,9 @@ Ext.define('PVE.panel.TagEditContainer', {
align: 'middle',
},
// set to false to hide the 'no tags' field and the edit button
canEdit: true,
controller: {
xclass: 'Ext.app.ViewController',
@ -241,6 +244,7 @@ Ext.define('PVE.panel.TagEditContainer', {
if (view.tags) {
me.loadTags(view.tags);
}
me.getViewModel().set('canEdit', view.canEdit);
me.mon(Ext.GlobalEvents, 'loadedUiOptions', () => {
view.toggleCls('hide-handles', PVE.Utils.shouldSortTags());
@ -253,11 +257,15 @@ Ext.define('PVE.panel.TagEditContainer', {
data: {
tagCount: 0,
editMode: false,
canEdit: true,
},
formulas: {
hideNoTags: function(get) {
return get('tagCount') !== 0;
return get('tagCount') !== 0 || !get('canEdit');
},
hideEditBtn: function(get) {
return get('editMode') || !get('canEdit');
},
},
},
@ -326,7 +334,7 @@ Ext.define('PVE.panel.TagEditContainer', {
cls: 'pve-tag-inline-button',
html: `<i data-qtip="${gettext('Edit Tags')}" class="fa fa-pencil"></i>`,
bind: {
hidden: '{editMode}',
hidden: '{hideEditBtn}',
},
listeners: {
click: 'editClick',

1
www/manager6/lxc/Config.js
View File

@ -186,6 +186,7 @@ Ext.define('PVE.lxc.Config', {
let tagsContainer = Ext.create('PVE.panel.TagEditContainer', {
tags: vm.tags,
canEdit: !!caps.vms['VM.Config.Options'],
listeners: {
change: function(tags) {
Proxmox.Utils.API2Request({

1
www/manager6/qemu/Config.js
View File

@ -222,6 +222,7 @@ Ext.define('PVE.qemu.Config', {
let tagsContainer = Ext.create('PVE.panel.TagEditContainer', {
tags: vm.tags,
canEdit: !!caps.vms['VM.Config.Options'],
listeners: {
change: function(tags) {
Proxmox.Utils.API2Request({