Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

gui: form/ControllerSelector: fix autoselection

Browse Source 
changing from Ext.Array.each to a for loop and changing the return
to a 'break', resulted in exiting the wrong loop (previously the outer,
now the inner) resulting in wrongly looping through all controllers
instead of only until we found a match

using a label and labeled break, we can break the outer loop

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2020-02-12 10:51:59 +01:00 committed by Thomas Lamprecht
parent cd4dde8d5c
commit 2de4c3bd34
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
www/manager6/form/ControllerSelector.js
View File

@ -54,13 +54,14 @@ Ext.define('PVE.form.ControllerSelector', {
clist = me.sortByPreviousUsage(me.vmconfig, clist);
}
clist_loop:
for (const controller of clist) {
bussel.setValue(controller);
for (let i = 0; i < PVE.Utils.diskControllerMaxIDs[controller]; i++) {
let confid = controller + i.toString();
if (!Ext.isDefined(me.vmconfig[confid])) {
deviceid.setValue(i);
break;
break clist_loop; // we found the desired controller/id combo
}
}
}