Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

ui: improve ACME edit/apply button visibilty

Browse Source 
multiple users were confused[0], as they did not interpret the 'icon only'
in the toolbar as a button (and it did not help that we prevented
the cursor to change)

to improve it, make the button a normal one again, and add some
text for context (this is more inline what we do elsewhere in toolbars)

0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2021-09-09 16:36:19 +02:00 committed by Thomas Lamprecht
parent 99bb257121
commit 3071423551
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
www/manager6/node/ACME.js
View File

@ -365,6 +365,7 @@ Ext.define('PVE.node.ACME', {
formulas: { formulas: {
canOrder: (get) => !!get('account') && get('domaincount') > 0, canOrder: (get) => !!get('account') && get('domaincount') > 0,
editBtnIcon: (get) => 'fa black fa-' + (get('accountEditable') ? 'check' : 'pencil'), editBtnIcon: (get) => 'fa black fa-' + (get('accountEditable') ? 'check' : 'pencil'),
editBtnText: (get) => get('accountEditable') ? gettext('Apply') : gettext('Edit'),
accountTextHidden: (get) => get('accountEditable') || !get('accountsAvailable'), accountTextHidden: (get) => get('accountEditable') || !get('accountsAvailable'),
accountValueHidden: (get) => !get('accountEditable') || !get('accountsAvailable'), accountValueHidden: (get) => !get('accountEditable') || !get('accountsAvailable'),
}, },
@ -606,10 +607,9 @@ Ext.define('PVE.node.ACME', {
{ {
xtype: 'button', xtype: 'button',
iconCls: 'fa black fa-pencil', iconCls: 'fa black fa-pencil',
baseCls: 'x-plain',
userCls: 'pointer',
bind: { bind: {
iconCls: '{editBtnIcon}', iconCls: '{editBtnIcon}',
text: '{editBtnText}',
hidden: '{!accountsAvailable}', hidden: '{!accountsAvailable}',
}, },
handler: 'toggleEditAccount', handler: 'toggleEditAccount',