Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

add ver get parameter for js/css files to improve cache behaviour

Browse Source 
we do not set an Expire header for our js files, and certain browsers
do not even make the request then (on which we would answer
with a correct 304 not modified)

so to force the browser to load a new version of the gui when we change
something, we add the package version as a get parameter

when doing this, the browsers still cache the file, until the get
parameter changes, which is exactly what we want

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Dominik Csapak 2017-08-09 14:08:26 +02:00 committed by Wolfgang Bumiller
parent 1faeea016b
commit 54165ad3ce
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
PVE/Service/pveproxy.pm
View File

@ -17,6 +17,7 @@ use PVE::APIServer::Formatter::Standard;
use PVE::APIServer::Formatter::HTML;
use PVE::APIServer::AnyEvent;
use PVE::HTTPServer;
use PVE::pvecfg;
use Template;
@ -200,6 +201,9 @@ sub get_index {
$langfile = 1;
}
my $ver = PVE::pvecfg::version();
my $release = PVE::pvecfg::release();
my $vars = {
lang => $lang,
langfile => $langfile,
@ -208,6 +212,7 @@ sub get_index {
console => $args->{console},
nodename => $nodename,
debug => $server->{debug},
version => "$ver-$release",
};
# by default, load the normal index

6
www/index.html.tpl
View File

@ -10,9 +10,9 @@
<link rel="stylesheet" type="text/css" href="/pve2/ext6/theme-crisp/resources/theme-crisp-all.css" />
<link rel="stylesheet" type="text/css" href="/pve2/ext6/crisp/resources/charts-all.css" />
<link rel="stylesheet" type="text/css" href="/pve2/fa/css/font-awesome.css" />
<link rel="stylesheet" type="text/css" href="/pve2/css/ext6-pve.css" />
<link rel="stylesheet" type="text/css" href="/pve2/css/ext6-pve.css?ver=[% version %]" />
[% IF langfile %]
<script type='text/javascript' src='/pve2/locale/pve-lang-[% lang %].js'></script>
<script type='text/javascript' src='/pve2/locale/pve-lang-[% lang %].js?ver=[% version %]'></script>
[%- ELSE %]
<script type='text/javascript'>function gettext(buf) { return buf; }</script>
[% END %]
@ -23,7 +23,7 @@
<script type="text/javascript" src="/pve2/ext6/ext-all.js"></script>
<script type="text/javascript" src="/pve2/ext6/charts.js"></script>
[% END %]
<script type="text/javascript" src="/pve2/js/pvemanagerlib.js"></script>
<script type="text/javascript" src="/pve2/js/pvemanagerlib.js?ver=[% version %]"></script>
<script type="text/javascript" src="/pve2/ext6/locale/locale-[% lang %].js"></script>
<script type="text/javascript">