Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

Update VM SCSI controller type after OS selection in Wizard

Browse Source 
This was done previously without any kind of user visible feedback, so users
would not know that they had a Virtio SCSI controller as default controller
for Linux VMs.

Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Emmanuel Kasper 2017-10-05 15:46:25 +02:00 committed by Wolfgang Bumiller
parent 2414ef153a
commit 7b2f6ac8af
3 changed files with 2 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
www/manager6/qemu/CreateWizard.js
View File

@ -1,7 +1,6 @@
Ext.define('PVE.qemu.CreateWizard', { Ext.define('PVE.qemu.CreateWizard', {
extend: 'PVE.window.Wizard', extend: 'PVE.window.Wizard',
alias: 'widget.pveQemuCreateWizard', alias: 'widget.pveQemuCreateWizard',
qemuScsiController: undefined,
controller: { controller: {
@ -167,10 +166,6 @@ Ext.define('PVE.qemu.CreateWizard', {
var nodename = kv.nodename; var nodename = kv.nodename;
delete kv.nodename; delete kv.nodename;
if (me.qemuScsiController && !kv.scsihw) {
kv.scsihw = me.qemuScsiController;
}
PVE.Utils.API2Request({ PVE.Utils.API2Request({
url: '/nodes/' + nodename + '/qemu', url: '/nodes/' + nodename + '/qemu',
waitMsgTarget: me, waitMsgTarget: me,

2
www/manager6/qemu/OSDefaults.js
View File

@ -66,7 +66,7 @@ Ext.define('PVE.qemu.OSDefaults', {
pveOS: 'w2k', pveOS: 'w2k',
parent : 'generic', parent : 'generic',
networkCard: 'rtl8139', networkCard: 'rtl8139',
scsihw: 'lsi' scsihw: ''
}); });
// https://pve.proxmox.com/wiki/Windows_XP_Guest_Notes // https://pve.proxmox.com/wiki/Windows_XP_Guest_Notes
addOS({ addOS({

10
www/manager6/qemu/OSTypeEdit.js
View File

@ -27,7 +27,7 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
me.setWidget('pveBusSelector', targetValues.busType); me.setWidget('pveBusSelector', targetValues.busType);
me.setWidget('pveNetworkCardSelector', targetValues.networkCard); me.setWidget('pveNetworkCardSelector', targetValues.networkCard);
me.setWizardHiddenValue('qemuScsiController', targetValues.scsihw); me.setWidget('field[name=scsihw]', targetValues.scsihw);
}, },
setWidget: function(widget, newValue) { setWidget: function(widget, newValue) {
// changing a widget is safe only if ComponentQuery.query returns us // changing a widget is safe only if ComponentQuery.query returns us
@ -38,14 +38,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
} else { } else {
throw 'non unique widget :' + widget + ' in Wizard'; throw 'non unique widget :' + widget + ' in Wizard';
} }
},
setWizardHiddenValue: function(property, newValue) {
var wizards = Ext.ComponentQuery.query('pveQemuCreateWizard ');
if (wizards.length === 1) {
wizards[0][property] = newValue;
} else {
throw 'non unique wizard, unable to set ' + property;
}
} }
}, },