Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

don't save password and double lines in pvesh history

Browse Source 
we assumed that Term::ReadLine does not put
input into the history automatically, but it does this

so if this feature is enabled, we do not have to add
the inputs manually, and we have to delete the password
from the history

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2016-08-03 11:09:45 +02:00 committed by Dietmar Maurer
parent ef0a000d8b
commit 9d9e015dda
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
bin/pvesh
View File

@ -189,6 +189,14 @@ my $read_password = sub {
my $input = $term->readline('password: ');
my $conf = $term->readline('Retype new password: ');
$attribs->{redisplay_function} = $old;
# remove password from history
if ($term->Features->{autohistory}) {
my $historyPosition = $term->where_history();
$term->remove_history($historyPosition);
$term->remove_history($historyPosition - 1);
}
die "Passwords do not match.\n" if ($input ne $conf);
return $input;
};
@ -558,7 +566,11 @@ while (defined ($input = $term->readline("pve:/$cdir> "))) {
exit (0);
}
$term->addhistory($input);
# add input to history if it gets not
# automatically added
if (!$term->Features->{autohistory}) {
$term->addhistory($input);
}
eval {
my $args = [ shellwords($input) ];