Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

ui: vm opts: clarify QGA option

Browse Source 
To make it more clear that PVE does not somehow magically injects a
QHA into the VM, but that this can be set if one has installed the
QGA in the VM themself.

So slightly adapt the label by prepending "Use" and adding a hint for
further details.

Also ensure we call it the real name everywhere, i.e., "QEMU Guest
Agent", this makes it a bit more consistent and easier to find
information for users.

Suggested-by: Aaron Lauterer <t.lamprecht@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2019-10-10 11:53:36 +02:00
parent aa5a717f3b
commit a729a92334
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
www/manager6/form/AgentFeatureSelector.js
View File

@ -7,7 +7,7 @@ Ext.define('PVE.form.AgentFeatureSelector', {
items: [ items: [
{ {
xtype: 'proxmoxcheckbox', xtype: 'proxmoxcheckbox',
boxLabel: gettext('Qemu Agent'), boxLabel: Ext.String.format(gettext('Use {0}'), 'QEMU Guest Agent'),
name: 'enabled', name: 'enabled',
reference: 'enabled', reference: 'enabled',
uncheckedValue: 0, uncheckedValue: 0,
@ -20,7 +20,15 @@ Ext.define('PVE.form.AgentFeatureSelector', {
disabled: '{!enabled.checked}', disabled: '{!enabled.checked}',
}, },
disabled: true disabled: true
} },
{
xtype: 'displayfield',
userCls: 'pmx-hint',
value: gettext('Make sure the QEMU Guest Agent is installed in the VM'),
bind: {
hidden: '{!enabled.checked}',
},
},
], ],
onGetValues: function(values) { onGetValues: function(values) {
@ -29,8 +37,7 @@ Ext.define('PVE.form.AgentFeatureSelector', {
}, },
setValues: function(values) { setValues: function(values) {
var agent = values.agent || ''; let res = PVE.Parser.parsePropertyString(values.agent, 'enabled');
var res = PVE.Parser.parsePropertyString(agent, 'enabled');
this.callParent([res]); this.callParent([res]);
} }
}); });

3
www/manager6/qemu/Options.js
View File

@ -252,12 +252,13 @@ Ext.define('PVE.qemu.Options', {
editor: caps.vms['VM.Config.HWType'] ? 'PVE.qemu.Smbios1Edit' : undefined editor: caps.vms['VM.Config.HWType'] ? 'PVE.qemu.Smbios1Edit' : undefined
}, },
agent: { agent: {
header: gettext('Qemu Agent'), header: 'QEMU Guest Agent',
defaultValue: false, defaultValue: false,
renderer: PVE.Utils.render_qga_features, renderer: PVE.Utils.render_qga_features,
editor: caps.vms['VM.Config.Options'] ? { editor: caps.vms['VM.Config.Options'] ? {
xtype: 'proxmoxWindowEdit', xtype: 'proxmoxWindowEdit',
subject: gettext('Qemu Agent'), subject: gettext('Qemu Agent'),
width: 350,
items: { items: {
xtype: 'pveAgentFeatureSelector', xtype: 'pveAgentFeatureSelector',
name: 'agent' name: 'agent'