Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

ui: iso selector: disable all fields to avoid bogus validation

Browse Source 
The validation logic of the inner fields from the ISO selector was not
disabled, so a user would need to select a valid storage and ISO file
before being able to make any other choice for the general CD-ROM
drive source (no-media or physical-drive).

Call the parent method to ensure all the inner fields get actually
disabled so that their validators also get disarmed if not relevant.

Reported in the communiy forum:
https://forum.proxmox.com/threads/136960/post-611704

Fixes: fc7b556d ("ui: refactor iso-selector out of the cd input panel")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
 [ TL: add more background to commit message/subject ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Fiona Ebner 2023-12-04 10:29:56 +01:00 committed by Thomas Lamprecht
parent 8113229eb7
commit ac7127388f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
www/manager6/form/IsoSelector.js
View File

@ -61,7 +61,7 @@ Ext.define('PVE.form.IsoSelector', {
let me = this;
me.lookup('storage').setDisabled(disabled);
me.lookup('file').setDisabled(disabled);
me.callParent();
return me.callParent([disabled]);
},
referenceHolder: true,