Proxmox/pve-manager
5
0
Fork 0
Code Pull Requests Releases Activity

jslint: fix _ prefix and 'for in' over an object

Browse Source 
jslint does not like names that begin with _

also it complains when you do not filter
a for in statement with a hasOwnProperty(property) as first
if statement

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2016-04-29 12:06:31 +02:00 committed by Dietmar Maurer
parent a764c5f72e
commit ca90044dac
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
www/manager6/Toolkit.js
View File

@ -239,10 +239,12 @@ Ext.define('Ext.ux.IFrame', {
try {
doc = this.getDoc();
if (doc) {
/*jslint nomen: true*/
Ext.get(doc).un(this._docListeners);
if (destroying) {
/*jslint nomen: false*/
if (destroying && doc.hasOwnProperty) {
for (prop in doc) {
if (doc.hasOwnProperty && doc.hasOwnProperty(prop)) {
if (doc.hasOwnProperty(prop)) {
delete doc[prop];
}
}
@ -264,6 +266,7 @@ Ext.define('Ext.ux.IFrame', {
// the event reaches listeners on elements like the document body. The effected
// mechanisms that depend on this bubbling behavior are listed to the right
// of the event.
/*jslint nomen: true*/
Ext.get(doc).on(
me._docListeners = {
mousedown: fn, // menu dismisal (MenuManager) and Window onMouseDown (toFront)
@ -274,6 +277,7 @@ Ext.define('Ext.ux.IFrame', {
scope: me
}
);
/*jslint nomen: false*/
} catch(e) {
// cannot do this xss
}