Commit Graph

2363 Commits

Author SHA1 Message Date
Dominik Csapak
3071423551 ui: improve ACME edit/apply button visibilty
multiple users were confused[0], as they did not interpret the 'icon only'
in the toolbar as a button (and it did not help that we prevented
the cursor to change)

to improve it, make the button a normal one again, and add some
text for context (this is more inline what we do elsewhere in toolbars)

0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-09-09 17:35:43 +02:00
Thomas Lamprecht
99bb257121 ui: backup job detail view: shrink code for set values of keep-X fields
makes it quite concise, but there's nothing really complex happening,
so should be still easy to grasp (especially with the comment added)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-09-08 16:14:02 +02:00
Thomas Lamprecht
28e7106b7f ui: backup job detail view: show retention settings in three columns
to safe vertical space for the actual guest+disk list

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-09-08 16:13:05 +02:00
Thomas Lamprecht
bf9391d3ef ui: backup job detail view: merge mail notification when/to fields
While it surely is nice to follow the layout of the job creation/edit
panel for sharing familiarity, it does not means that we need to show
the data 1:1, we can profit from the read-only fact and merge stuff a
bit, like the mail to/when field.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-09-08 16:09:45 +02:00
Thomas Lamprecht
3a31f11029 ui: backup job detail view: simplify node renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-09-08 16:09:19 +02:00
Thomas Lamprecht
1a871dea0d ui: backup job detail view: simplify enabled renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-09-08 13:38:25 +02:00
Fabian Ebner
2e5e4770e3 ui: backup job detail: also show retention settings
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-09-08 13:37:11 +02:00
Thomas Lamprecht
626838222a ui: backup job detail view: fix coding style, xtype goes first
the code is unnecessarily hard to read else and goes against our
common style.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-09-08 13:37:11 +02:00
Fabian Ebner
971bbdc561 ui: prune: fix order of keep reasons
This is the same as fix 40ff84b138bb7127ecc05a2f587cca4e7a917810 in
proxmox-backup. When returning a boolean instead of the expected
{negative, 0, positive}, the behavior is browser-dependent.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-09-08 12:58:53 +02:00
Thomas Lamprecht
1f30e66155 ui: rename pveEditPruneInputPanel to pveBackupJobPrunePanel
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-09-08 12:56:15 +02:00
Fabian Ebner
6022f36fd0 fix #1803: ui: cluster backup: handle job-specific retention options
This was already possible via API (or manually editing vzdump.cron)
for a long time, but the settings were not visible in the UI at all.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-09-07 11:13:18 +02:00
Fabian Ebner
ae361a8632 ui: prune edit: prepare for being re-used for backup jobs
1. Rename the isPBS variable to match the actual purpose. When editing
a backup job, the hint should not be shown, even if the storage is
PBS.

2. Allow specifying the text used for the fallback hint. For backup
jobs, the first fallback is the storage configuration, so the text
needs to be different there.

3. Make using keep-all=1 by default upon creation optional. For backup
jobs, the default should be "use fallback", i.e. no settings.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-09-07 11:13:18 +02:00
Fabian Ebner
d1ec698659 ui: factor out input panel for editing prune settings
To be re-used for configuring job-specific retention options for
backups.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-09-07 11:13:18 +02:00
Fabian Ebner
7f14fad199 ui: cluster backup: fix running backup with prune settings
The API expects a property string for retention settings, so make sure
that's what's passed in.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-09-07 11:13:18 +02:00
Thomas Lamprecht
0ec27ecb7e ui: dc: add comment to odd condition for showing SDN
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-08-24 11:13:28 +02:00
Oguz Bektas
eda2d13675 utils: add missing 'tfa' for @pve realm
was missed in commit 92e7ce43e1

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2021-08-05 13:14:49 +02:00
Dominik Csapak
e95be90fe4 ui: lxc/CreateWizard: add a 'nesting' checkbox and enable it by default
but only enable the field for unprivileged containers.
We do this, since newer containers need this feature for basic
functions.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-08-04 13:40:53 +02:00
Dominik Csapak
338a307eda ui: lxc/Options: allow opening features window for VM.Allocate
since VM.Allocate can at least change the nesting value

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-08-04 13:40:42 +02:00
Dominik Csapak
e04818b291 ui: node/ZFS: add zstd to possible compression methods
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-07-30 17:04:05 +02:00
Dominik Csapak
a102e99558 ui: qemu/PCIEdit: change onlineHelp link to vm config section
link the user directly to the vm config section of the pci
passthrough docs, since that is whats happening on that panel.

It still is on the same page as the whole passthrough docs, so
the remaining info is still there.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-07-30 14:49:14 +02:00
Fabian Ebner
7448175d4a ui: node status: use repo status widget from widget-toolkit
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-07-29 10:47:02 +02:00
Mira Limbeck
e1408fb6fc ui: remove local cloud-init live migration limitation
With live migration with local cloud-init disk now possible via the CLI
also remove the limitation in the GUI.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
2021-07-29 10:42:51 +02:00
Lorenz Stechauner
ceec3f6909 fix #3426: ui: parser: adapt parseSSHKey to accept "@..." suffix
also rearranged the regex groups to allow sk-ecdsa-sha2-...

note: FIDO keys are now parsable, the backend only supports it with
OpenSSH >= 8.2. This may be achieved with upgrading to PVE 7 or
using a back port.
2021-07-23 09:05:33 +02:00
Thomas Lamprecht
b18c1b466e ui: state provider: comment text width/indentation cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-16 15:17:23 +02:00
Fabian Ebner
166057e16f ui: node: repos: add online help
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-07-15 14:38:49 +02:00
Dominik Csapak
ed10359a04 ui: ceph/Status: fix recovery percentage display
we incorrectly used 'total' as 100% of the to recovered objects here,
but that containst the total number of *bytes*.

rename 'toRecover' to better reflect that the unit is 'objects' and
use that as total

reported by a user:
https://forum.proxmox.com/threads/bug-ceph-recovery-bar-not-showing-percentage.91782/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-07-07 18:08:34 +02:00
Aaron Lauterer
403476f8ef ui: ha/ressources: fix toggling edit button on selection
It needs to be a 'proxmoxButton' to get activated when selecting a HA
ressource. This was lost during the last code cleanup, commit a69e943.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-07-07 14:20:16 +02:00
Thomas Lamprecht
d2a91505cd ui: iscsi: code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-06 12:38:02 +02:00
Thomas Lamprecht
3438022241 ui: cifs: do not send empty user/password
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-06 07:38:47 +02:00
Thomas Lamprecht
6790843335 ui: notes edit: set markdown basic as onlineHelp
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 15:35:46 +02:00
Thomas Lamprecht
20b97fde1c ui: node status: prioritize non-production and fix ok case
Non-production repositories will always pull in their newer software,
so even if enterprise+subscription is OK we should mark it with
priority if, e.g., pvetest is enabled.

There was also a bug regarding the all OK state

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 15:33:45 +02:00
Thomas Lamprecht
bfbf9aa7ea ui: node status: rework repo status texts/icon
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 14:47:17 +02:00
Thomas Lamprecht
dafbe48c88 ui: dc/guests: set line-height again and increase font-size
the 14px over 13px is not much, but as that is the font-size intended
for font-awesome it makes it all look nicer together

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 12:58:50 +02:00
Thomas Lamprecht
3012331485 ui: dc/guests: avoid using <br> for layouting
use a flex box with centered columns instead, that needs adding a div
per row, but that's IMO actually making it more clear what a row is
anyway.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 12:58:47 +02:00
Thomas Lamprecht
cf599b2f29 ui: dc/Guests: make update lazy
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 12:20:13 +02:00
Thomas Lamprecht
8f3ec5df59 ui: dc/Guests: fix indentation
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 12:20:13 +02:00
Stefan Reiter
cee295f652 ui: dc/guests: remove 'line-height' from default style
Firefox doesn't correctly break to the next line if the line-height
is set as is (with certain fonts, including the default on debian it
seems). Simply remove it, as it isn't necessary.

Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2021-07-05 12:19:40 +02:00
Thomas Lamprecht
82d2e6a987 ui: node summary: slightly increase panles height
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 10:58:57 +02:00
Thomas Lamprecht
686244c44f ui: status: improve reuse of gettext
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 10:47:58 +02:00
Thomas Lamprecht
7068531e11 ui: fix yet another bogus broken gettext usage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 10:24:43 +02:00
Thomas Lamprecht
4edb3b6a13 ui: notes: add empty text with a hint that markdown is supported
We can do so unconditionally as this is a PVE specific component and
only used for guests and nodes, both using the markdown Parser.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 08:29:29 +02:00
Thomas Lamprecht
4646e549c8 ui: node status: small code size reduction
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 22:09:36 +02:00
Thomas Lamprecht
74cb313052 ui: node/status view: padding-reduce fixup
overlooked the inline one, and that caused some layout troubles

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 22:09:17 +02:00
Thomas Lamprecht
bbd82b38f1 ui: node/status view: reduce quite generous paddings
As both, the whole panels body and the actual items all had their own
padding it added up quite a bit.

Some padding is good to avoid elements being "glued" to the parent
borders, but that can be done with also with ~15 px vs. 30 px on each
side, so no need to waste that much extra space we can use in some
languages to render content

Added benefit, the status panel now is more in sync with the RRD
panels regarding content start/end.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 21:52:05 +02:00
Thomas Lamprecht
2e65b4e43d ui: node summary: rework repo status output
the icon on the left side look a bit weird here, as the lines
directly above had none and the actual status which the icon tried to
emphasize is on the right anyway.

Rework also the output.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 21:18:43 +02:00
Thomas Lamprecht
6987404447 ui: node summary: followup code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 21:17:35 +02:00
Fabian Ebner
a703426a83 ui: node summary: show repository configuration status
I tried to use itemid and lookupreference for the nodeStatus item, but couldn't
get it to work, so I factored it out.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-07-04 20:58:33 +02:00
Thomas Lamprecht
a3696e93f7 workspace: set title to header for aria
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 18:28:11 +02:00
Thomas Lamprecht
788588cb86 utils: enable ARIA again
We had done so already in PBS and PMG since a bit without seeing
anything broken due to it, which makes sense as this was enabled for
*during* the step-by-step upgrade from ExtJS 4 to 5 (and then
directly 6).

Re-enabling  could help with some accessibility issues we have some
tangential reports[0].

[0]: https://github.com/nvaccess/nvda/issues/11530

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 18:23:47 +02:00
Thomas Lamprecht
75a38218b2 ui: rework global searchfield, drop cruft, improve readability
Single letter variable names really do not help understanding what's
going on, as do overly general names like fields for the split up
words we actually search+filter for.
Using a switch block as map is often also not ideal (way more syntax
noise and style hacks like break on the same line to keep it
compact), rather just use an actual object map.

Some of the improvements where not possible when this was
implemented, as then we ensured < es5 compat for IE 10 support.

With for-of and nullish-chaining a few things to get nicer to
express.

While at it also fix comment text width making them less look like
haikus and improve match calculation comment to avoid implying that
match is either 0, 1 or 2, it can be higher too (if multiple columns
match).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 18:10:02 +02:00