36 Commits

Author SHA1 Message Date
Nicholas Sherlock
b7a84230ed ui: pci passthrough: editor for pci-id overrides
Signed-off-by: Nicholas Sherlock <n.sherlock@gmail.com>
2022-01-25 11:17:05 +01:00
Thomas Lamprecht
028827fc24 ui: toolkit: eslint fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-17 17:30:39 +02:00
Thomas Lamprecht
9beb47513e ui: eslint: fix trailing comma and comma related whitespaces errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:31:03 +01:00
Wolfgang Bumiller
bacab23773 ad #3140: allow interface suffix in dns entries
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2020-11-25 12:33:54 +01:00
Thomas Lamprecht
fbfcef596f ui: rbd: storage: obsolete strange getBinds binding assembly
this was added for our (also in other places used):
> xtype: me.isCreate ? 'pveCephPoolSelector' : 'displayfield',
construct. But as displayfield does not has a submitValue setter we
cannot bind it generally.

So add such a setter with a small override and declare the bindings
direct when declaring the items, less side effects and all the
configurations for an item stays in the same place.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-19 10:40:49 +01:00
Dominik Csapak
60e6e5a42c add IP64AddressList vtype
this can be used for DNS Server list

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-03-16 10:05:57 +01:00
Thomas Lamprecht
839a53d79a reuse Toolkit from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
1037c130f3 dc/OptionView: cleanup & use new features from ObjectGrid
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Dominik Csapak
42ec18721b use Proxmox.Utils instead of PVE.Utils
some function are now in Proxmox.Utils instead, so we have to use that

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:38 +01:00
Dominik Csapak
484bf3f29e fix #1516: fix mouse-scrolling of overflowhandlers in firefox
this is a workaround for scrolling in toolbars, etc. in firefox with the
mouse

while the result is not very "pretty", it maintains the old behaviour
for all other browsers and makes it work in firefox

we can drop this when we update to a new extjs release

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-06 07:54:55 +02:00
Dominik Csapak
e6f2a94f4f fix #1510: do not scroll back to focus when view gets refreshed
this adds a workaround, so that we restore the scroll position
when we restore the focus

with the flag 'jumpToFocus', we can enable the old behaviour

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-04 10:57:33 +02:00
Dominik Csapak
4e831933c7 add override for correct defaultButton behaviour
we disable the defaultButton behaviour on textarea and aria-multiline
fields, else we cannot input a newline into a textarea on a form with
a defaultButton defined

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-06-02 16:16:11 +02:00
Dominik Csapak
5c660b6d13 fix #1307: dont use language dependent separator in gui
by default, extjs submits the language dependent decimal separator,
e.g. ',' for german and '.' for english

but we always want '.'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-03-21 13:50:28 +01:00
Dominik Csapak
d19ffc1bb0 remove unneeded applyEmptyText
this was not needed and does not work with extjs 6.2

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-03-09 10:43:13 +01:00
Dominik Csapak
7f1eca8dc2 fix #1175: make error messages more verbose
the error messages for several input fields (e.g. snapshot name)
did not correctly reflect the regex which was checked

this patch adds additional information about the required format

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-10-20 17:25:57 +02:00
Emmanuel Kasper
ccba60877b Move globally defined regexpes into PVE.Utils
Those globally defined regexpes were only used in Toolkit.js
2016-10-18 12:40:47 +02:00
Dominik Csapak
6d0345e2f8 correctly reset value of combobox
we have cases, were the original value of a combobox is an array,
but not the current value

on reset, we get an error in Ext.Array.equals, because we
did not check if the current value is also an array

this patch fixes this

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-10-07 08:34:11 +02:00
Dominik Csapak
e00bba5a9d add HostList validator and check monhosts with it
this adds a vtype which splits the given string into a list by
; or , or space
and checks if it is a valid (hostname|ip) port notation

also make the rbd monhost input field use it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-07-15 11:53:05 +02:00
Dominik Csapak
44f800ae91 refactor DnsName regex
we will need this again

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-07-15 11:53:05 +02:00
Dominik Csapak
588df52a7e fix combobox reset behaviour
on comboboxes/combogrids with multiselect,
if you deselect an item (but not the last),
the order of the selected items after resetting is
not the same as the original order

because of this, the reset button is still enabled

this happens, because extjs only adds the missing
values instead of overwriting the whole array

with this fix, we overwrite the reset function of
the comboboxes and only if the values do not match
(after a reset) do we clear and set the value again

so we only change the behaviour when it is necessary

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-05-03 06:06:58 +02:00
Dominik Csapak
323d0f14e2 jslint: fix _ prefix and 'for in' over an object
jslint does not like names that begin with _

also it complains when you do not filter
a for in statement with a hasOwnProperty(property) as first
if statement

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:08:33 +02:00
Dominik Csapak
79786b96e5 jslint: fix missing or extra semicolon
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:07:42 +02:00
Dominik Csapak
1178163a05 jslint: add global entries where necessary
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:59 +02:00
Dominik Csapak
14986f7491 jslint: remove trailing commas
before ECMA5 trailing commas in arrays and objects
are forbidden

in jslint this is an error and cannot be deactivated

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:34 +02:00
Dominik Csapak
1b51cd2a29 jslint: fix type confusion and property access
fix various type confusion, for example:
items: {} and items: []
style: string and style: {}

also fix object['property'] access with
object.property

also fix /=/ with either '=' or /\=/ where appropriate
(/=/ can be confused with /= according to jslint)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:23 +02:00
Dominik Csapak
78b5290fab improve gui cidr matching
with this fix, we (again) allow ipv4 cidr to be as low as 8
also check the cidr for ipv6 and show the valid ranges in the
error text

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-28 10:57:41 +02:00
Emmanuel Kasper
f062279764 Overrides Ext.Msg.alert() to always display an Error Icon 2016-04-07 16:52:48 +02:00
Dietmar Maurer
6ff38900fa reduce translation overhead 2016-04-05 11:10:52 +02:00
Thomas Lamprecht
37d33bc8a5 ext6: datepicker workaround
Witouth this we can get into issues where only the picker is visible
and the rest of the GUI is completely grey when selecting a date
with the date picker, generally this happens when a scroll field is
involved (e.g., syslog).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2016-03-15 12:45:40 +01:00
Dominik Csapak
a56c7e211b ext6migrate: fix trailing whitespaces
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-14 17:18:46 +01:00
Dominik Csapak
abf21f2ff9 ext6migrate: remove unecessary hacks
this removes the two overrides for extjs4

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-14 17:18:18 +01:00
Dominik Csapak
c13ddf6132 ext6migrate: fix framework caching issue
in extjs 5/6 there is a caching issue, where they
save dom elements for reuse, but the garbage collector
can set them to null

when the framework now reuses the "cached" element it is null,
and any action on it produces an error, which breaks the site

for details see the forum link in the comment

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-14 17:16:58 +01:00
Dominik Csapak
a2d6bf2b56 ext6migrate: fix fullscreen for noVNC
add allowfullscreen to iframe code, makes novnc fullscreen work

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-02-29 12:33:43 +01:00
Dominik Csapak
ed15db794d ext6migrate: update Ext.ux.IFrame code in Toolkit.js
update to current code from framework
makes it working again

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-02-27 09:26:28 +01:00
Emmanuel Kasper
030910b2b0 Allow email adresses with a top level domain of up to 63 characters
Reapply fix for  https://bugzilla.proxmox.com/show_bug.cgi?id=716
which was missing in manager6/ directory
2016-01-22 11:24:14 +01:00
Dietmar Maurer
bd5d277292 rename manager5 to manager6 2016-01-22 11:24:10 +01:00