1110 Commits

Author SHA1 Message Date
Dominik Csapak
676b5a9e9f move DiskSelector to its own file, for generic use
also set the default diskType to undefined and
change the api endpoint to /nodes/NODE/disks/list

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-08-02 12:40:45 +02:00
Thomas Lamprecht
2380c1f0f4 ui: storage: combine RBD external and hyperconverged add dialog
Combine both dialogues. This reduces storage choices from the
Storage -> Add menu, and thus improves usability.

We make the whole dialog also more intelligent by querying the
monitors, so that we can show them for the hyper converged case
keeping a similar interface for both cases. Further we can use this
to decide if a hyperconverged setup is possible at all.
While this information would also be available through the fact if
the pool selector has entries I wanted to show them anyway and could
make logic a bit easier using it.
2018-07-31 14:04:57 +02:00
Dominik Csapak
93c13afeb6 fix doubleclick on vm with spice console
allowSpice needs to be a real boolean, because of a
'=== true' check to open a spice console if allowed, so make it one here

this fixes the issue that a doubleclick on a tree item only opened
the novnc console even if spice is the default and the vm is spice
enabled

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-07-30 11:53:33 +02:00
Thomas Lamprecht
6df496780b ui: permissions: allow to select root path '/' directly
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-25 10:18:12 +02:00
Dominik Csapak
f92c0b1e30 set resize to 'off' for the novnc popup
this makes it easier to handle the resize parameter in novnc code

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-07-23 11:19:40 +02:00
Dominik Csapak
74f61c5038 improve xtermjs settings button behaviour
we now put a form around the fields/buttons and can track
the valid/dirty state, and use this for setting the button states

now the buttons are correctly enabled/disabled when the form
is dirty/valid/empty

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-07-19 10:38:01 +02:00
Andrew Neitsch
44adc3c6ee Submit pool if non-empty in lxc CreateWizard
The lxc CreateWizard ignores the pool setting. That makes creating
containers impossible for users who are restricted to using a pool. This
patch fixes that.

Signed-off-by: Andrew Neitsch <andrew@neitsch.ca>
2018-07-11 07:25:48 +02:00
Thomas Lamprecht
e4867d90a0 ui: vm hotplug selector: refactor for sane formatting
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-06 08:05:48 +02:00
Thomas Lamprecht
9f3e15b32d ui/storage: cifs: reoder fields
username, password and domain name are all related, they are non-pve
options related to accessing the CIFS storage and have all influence
on the pveCIFSScan component.
So group at kleast user and password together. But keep domain on the
right for the sake of balance.
Move the content type selector to the right, as the RBD and other
panels do.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-02 10:25:14 +02:00
Thomas Lamprecht
e3179cf3e5 ui/storage: cifs: exit early from username change cb on displaying
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-29 13:00:15 +02:00
Thomas Lamprecht
f3dd3fddf1 ui/storage: cifs: only allow entering a password if user is set
we ignore the password in the backend if no user is passed,
which can be very confusing for the user - or more important, me,
when testing cifs/storage stuff.

So change the mechanics slightly. Previously we changed the
allowBlank property of the password field if username was changed.
I set it to always required, but disable the whole field if we do not
have a username.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-29 12:55:28 +02:00
Thomas Lamprecht
574476c2b3 trivial: ui: cifs: cleanup unnecessary lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-29 12:54:00 +02:00
Thomas Lamprecht
a0b94e227a ui/ct: add autostart-after-create checkbox to wizard
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-18 10:34:48 +02:00
Thomas Lamprecht
3b02fb3350 ui: add auostart after create checkbox
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-12 09:45:05 +02:00
René Jochum
7e2d420450 Remove swap/memory limit in the Manager, fixes #1799 2018-06-07 13:44:21 +02:00
Stoiko Ivanov
c41302b114 add ebtables option to cluster firewallsettings
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2018-06-06 15:52:11 +02:00
Dominik Csapak
3e0576d151 fix notes gear tool
me was used before it was defined

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 17:30:22 +02:00
Dominik Csapak
b631683863 indentation fixes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 17:24:49 +02:00
René Jochum
67f413c2a8 fix #1499 Implement a combobox for Permissions paths
Signed-off-by: René Jochum <r.jochum@proxmox.com>
2018-05-25 17:19:07 +02:00
René Jochum
6c0d184e66 Modernize PVE.form.GroupSelector,
as example for future Uses.

Signed-off-by: René Jochum <r.jochum@proxmox.com>
2018-05-25 17:19:07 +02:00
Dominik Csapak
5d917db1c0 fix #427: add notes panel to node
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 11:04:08 +02:00
Dominik Csapak
842a74cd5d accept type 'node' for NotesView and refactor it
so that we can use it for the notes of a node,
also changes the configuration to a static declaration,
this adds an 'edit' button for the node panel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 11:04:08 +02:00
Dominik Csapak
b3496559db let NotesView load itself
instead of needing to load from the outside, let NotesView handle the
loading itself

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 11:04:08 +02:00
Dominik Csapak
45d9186da6 correctly update qemu ip information
we updated the status from the status store too often, so that
if the guest agent was not running, the message would
change between 'no information' and 'not running'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 10:44:05 +02:00
Dominik Csapak
b6027a95da only show 'more' buttons for ips when there are actually ips to show
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 10:43:59 +02:00
Dominik Csapak
4783fd448f check for VM.Montior privileges on qemu AgentIPView
so that the user does not get the useless 'no information' or
'not running' message, but the real cause

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 10:43:47 +02:00
Thomas Lamprecht
870899f183 ui: use cbind to make usb input panel static
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-18 15:39:54 +02:00
Dominik Csapak
d80195e556 correctly parse iscsi content
we parse the content as a list, so it is always an array

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-18 12:18:07 +02:00
Thomas Lamprecht
6348ef44ec ui: dc/storage: allow to renenable iscsi storages again
The dc/storage refactoring done in
commit 8f60ee4ccacc14f1bbe025874522c151cc375f83
introduced a regression where an once deactivated iSCSI storage could
not be activated again through UI, as we did not called the parent
setValue function correctly, thus the Enable checkbox was always set
to true. A uncheck -> check cycle couldn't also be done as the dirty
changes check disabled the submit button in this case.

Enable/Disable through API or CLI still worked.

Reported-by: Bastian Sebode <b.sebode@linet-services.de>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-18 12:09:57 +02:00
Thomas Lamprecht
62bc2f4827 ui: vm: allow to add socket backed serial devices
We show and can remove serial devices but couldn't add new ones
through the WebUI.
Add a simple component to allow adding serial ports backed by a
socket, which can be especially useful now with xterm.js

Passing through serial devices from /dev isn't possible with this, as
it is normally a root only operation and not that often used.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-17 09:25:34 +02:00
Thomas Lamprecht
5878b25d16 fixup: jslint errors
fix some small problems where jslint complains, introduced by
commit: 9265782932cdbcf8e6c7781aec437d06a22048d4

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-16 10:05:07 +02:00
Dominik Csapak
474758b9d1 add missing onlineHelp links
for:
* dc/Cluster
* node/Certificates
* qemu/CloudInit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-14 12:01:39 +02:00
Thomas Lamprecht
c3ed131305 ui/UserEdit: fixup grammar in password match error message
Passwords is plural, so it needs "do", not "does".

We already have the "do" version translated as it is used by the PMG
so this adds no new string.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-09 11:14:25 +02:00
Dominik Csapak
7d3efde9a1 hide irrelevant buttons and tabs for container templates
like we do with vm templates

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-08 16:08:16 +02:00
Thomas Lamprecht
755f44ce61 trailing whitespace fixup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-08 16:07:47 +02:00
René Jochum
9265782932 fixes #1503 Add role CRUD to the GUI.
As given in the subject this implements role create/update/delete over
the manager.

There's currently no coler highlightning for "special" roles.

Signed-off-by: René Jochum <r.jochum@proxmox.com>
2018-05-08 15:54:22 +02:00
Dominik Csapak
d26eb607b4 add _blank target for optional url
so that they open in a new tab/window

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-08 13:38:09 +02:00
Dominik Csapak
30e5d15eee add container move volume to gui
this reuses the vm HDMove window to move volumes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-07 14:55:49 +02:00
Dominik Csapak
dc807a3e79 make HDMove.js also usable for lxc
this makes it possible to reuse the window for container move_volume

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-07 14:55:49 +02:00
Dominik Csapak
9705ba7f48 close HDMove on taskDone
this triggers the 'destroy' event of the window at the correct time

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-07 14:55:49 +02:00
Thomas Lamprecht
648ed68866 ui/acme: remove 'Renew Cert' button for now
You can normally do this with the Order Cert button, with almost the
same result, and it isn't something which will be needed often, if
the UI is somehow inaccessible (due to cert problem) then this is
useless anyway, and the CLI must be used anyhow.

Can be easily reverted if we deem this necessary later on.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-04 16:21:11 +02:00
Dominik Csapak
80d50f89cd add node/Certificates.js and use it
this adds the grid for showing the custom/builtin Certificates
and the means to upload and delete custom ones

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-04 16:11:00 +02:00
Dominik Csapak
e097a60260 add node/ACME.js
this provides the grid for editing domains for letsencrypt,
order/renew the certificates, and the window for creating an
ACME account

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-04 16:11:00 +02:00
Dominik Csapak
80e95f9c99 add render functions for Certificates
this adds render_optional_url for a field which may contain a link
and render_san which simply displays the different values
in each line

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-04 16:11:00 +02:00
Dominik Csapak
94662e2c90 disable the mountpoint selector and path field by default
since in the wizard, the validity check happens before the
viewmodel can set the visible/enabled state so this is invalid there,
even if the remaining panel is valid

setting it to disabled by default, makes the fields 'valid' at the
beginning but retain their behavior

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-02 08:28:29 +02:00
Dominik Csapak
2253a5ead5 show qmpstatus if available
this patch shows the qmpstatus if it is available on the summary in
parenthesis

this shows things like 'suspended' and 'io-error'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-30 11:02:08 +02:00
Dominik Csapak
7e2add23be implement multiField renderer for infopanels
we can use this for fields which use more than one value of the
guest status

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-30 11:02:08 +02:00
Thomas Lamprecht
8368c3b0d9 dc/ClusterEdit: join: fix assisted entry chechbox change listener
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-04-27 15:47:41 +02:00
Dominik Csapak
b4cdf78629 jslint fixes
those found their way in during a rebase of my patches

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-25 11:56:09 +02:00
Dominik Csapak
5c47f4fddb use correct multiKey and getObjectValue calls for memory line
also show shares and if ballooning is off

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-23 12:12:47 +02:00