158 Commits

Author SHA1 Message Date
Dominik Csapak
a47add8dbe ui: ResourceGrid: move first update to afterrender
else with extjs 7.0, the first render does not happen yet, because
the grid is not visible at that time

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:43:08 +02:00
Dominik Csapak
9088ebc96d ui: ResourceGrid: correctly remove ResourceStore listener
while the function in '.on' and '.un' are identical, they are not the
*same* function, thus the '.un' does not really remove the listener,
and we have leftover references to the grid which means it will never
really garbage-collected

instead, use '.mon' on the grid, which automatically cleans up the
listeners

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-20 21:01:49 +02:00
Thomas Lamprecht
eb7a2b5dda ui: grid/Resources: eslint fixes and code cleanup/refactoring
this is a major cleanup, using the current ExtJS and ES2018 features
allows to do a lot more concise and nicer.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-18 18:02:27 +02:00
Thomas Lamprecht
83af7f863d ui: grid/Replication: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-18 18:00:30 +02:00
Thomas Lamprecht
a372e3ddfb ui: grid/Firewall: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-18 17:59:16 +02:00
Thomas Lamprecht
229d954101 ui: backup views: unfiy button order in storage and guest backup view
and group better, avoid alternating by destroying and restoring
button (prune, file restore, remove) and place file restore and
restore together

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 16:46:10 +02:00
Thomas Lamprecht
8f11948db7 ui: guest backup grid: hide file-restore button if not a PBS storage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 16:44:58 +02:00
Fabian Grünbichler
22bc574ef9 file-restore: pass in full volume ID
not just the snapshot name.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2021-04-23 15:32:10 +02:00
Stefan Reiter
5c6cb499ff backupview: add file restore button
Adds it for both BackupViews, on VM view and storage view.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2021-04-23 15:32:08 +02:00
Aaron Lauterer
1476fa0345 ui: firewall: rule: maxlength for source and dest
Limiting the length of the source and dest paramters helps to avoid
problems with iptables-restore which would not apply a rule if a
parameter is larger than the parameter buffer (1024)[0]. As the API is
already limiting this, we should also reflect that in the GUI and give
people a hint that IP sets are most likely the better approach.

[0] http://git.netfilter.org/iptables/tree/iptables/xshared.c?h=v1.8.7#n469

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-04-22 21:33:37 +02:00
Stefan Reiter
3fa9842ac8 ui: restore: add live-restore checkbox
Add 'isPBS' parameter for Restore window so we can detect when to show
the 'live-restore' checkbox.

Includes a warning about this feature being experimental for now.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2021-04-15 17:18:40 +02:00
Dominik Csapak
09a4cab6d4 ui: backups: enable editing notes for Proxmox Backup Server
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-03-25 09:20:46 +01:00
Thomas Lamprecht
a6101d1f55 ui: firewall grid: try balance between flex and good overview
Recently, with the Proxmox Backup sync/verify/.. job grids I had to
change my mind regarding use of flex, overuse of it is as bad as
having all to fixed widths as it spreads out the data a lot on big
screens, making it hard to follow as lots of eye movement is
required.

What we ideally would have is a "maxFlexWidth", i.e., a maximal
auto-flex width which still allows wider columns if a user manually
drags it wider. "maxWidth" comes close, but is a hard limit and so
use it only in cases where its quite clear that wider columns make no
sense (surely someone will disagree even for those, but well...).

Basic solution is to add lots more flex ratio to comment so that the
others won't get to big fast, keeping the actual relevant config of a
rule somewhat close by (thus easier to read/grasp/parse)

Also move the source/destination port columns after their direction
column and abbreviate their header title.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-02-22 14:36:33 +01:00
Thomas Lamprecht
ba3e230317 ui: firewall grid: rename Enable column to shorter On
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-02-22 14:30:08 +01:00
Thomas Lamprecht
08a758ee2e ui: firewall grid: fix rendering comment, only show tooltip when truncated
avoid showing "undefined" if there's no comment, renderer must not
return null or undefined directly, it will converted to string as is,
so always fallback to '' empty string

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-02-22 14:28:38 +01:00
Aaron Lauterer
ad7c269b21 ui: FirewallRules: Add tooltip to comments
The comment columns might not be wide enough for longer comments. Since
it is the most right columns, it can be tricky to grab the right pixel
to drag it wider.

A tooltip that shows up on hover should be okay.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-02-22 13:46:31 +01:00
Aaron Lauterer
0afc93fdff ui: FirewallRules: make columns flexible
Changing the width definitions to use flex will make better use on
larger monitors. Changing the `width` parameter to `minWidth` ensures
that on smaller screens it is still usable, though some horizontal
scrolling might be necessary.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-02-22 13:46:31 +01:00
Thomas Lamprecht
df156f8ba1 ui: eslint: enforce "no-extra-parens" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:42:36 +01:00
Thomas Lamprecht
8b520a2b6f ui: eslint: fix various spacing related issues
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:39:15 +01:00
Thomas Lamprecht
9beb47513e ui: eslint: fix trailing comma and comma related whitespaces errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:31:03 +01:00
Thomas Lamprecht
925ef9da87 ui: eslint: fix trailing spaces
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:29:55 +01:00
Dominik Csapak
a56e027be9 ui: fix usage of findRecord
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-26 10:52:07 +01:00
Thomas Lamprecht
9c3eaf9f75 ui: factor out backup verification renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-24 23:35:39 +01:00
Thomas Lamprecht
be88698028 ui: guest backup view: add encrypted column for PBS storages
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-24 23:35:15 +01:00
Thomas Lamprecht
5bb7b2dc98 ui: guest backups: add separator, fix left-over Comments title
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-24 14:26:18 +01:00
Dominik Csapak
6f2e578024 ui: add ability to show and edit comments for backups
for now we filter out pbs storages

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-24 13:47:07 +01:00
Dominik Csapak
5e8f8fa3dc ui: change comment column to notes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-24 13:47:07 +01:00
Thomas Lamprecht
6d3d5de5df ui: content/backup-view: move comment to second col, make flex
to make it more look like what we to in PBS

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-12 18:34:38 +01:00
Thomas Lamprecht
5a5a7c1a37 ui: storage content: fix verify time tooltip
this was partial copied over from PBS, but there we pull out the task
startime alreay when building the store.

As eslint mentions, task was unused, verify_time not defined, fix
that.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-12 18:31:17 +01:00
Thomas Lamprecht
e78f9bfc84 eslint fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-11-12 18:23:47 +01:00
Dominik Csapak
5e6bf13276 ui: add comment/verification columns to backup/content grid
verification column only shows in the backup grid and for
pbs storages

(renderer is mostly copied from proxmox-backup)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-12 18:14:53 +01:00
Aaron Lauterer
4176774b5a ui: FirewallRules.js: fix #3049 wider rule number column
Allows 2 digits rule numbers to be visible in the column. Made it a bit
wider than needed to account for potentially wider font rendering on
different platforms.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-10-01 16:35:26 +02:00
Dominik Csapak
017f991c91 ui: fix unchecking 'Filter VMID'
if the checkbox is not checked, we set the value of the vmid filter to ''
but left 'exactMatch' enabled, which means we filter all out where
the vmid is not ''

what we instead want is to remove also the exactMatch so that we
get *all* entries back not *none*

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-09-25 09:06:43 +02:00
Dominik Csapak
f9f2aaaec2 ui: filter on exact vmid
so that backups of vmid 1000 do not show up on vm 100 with 'filte vmid'
enabled

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-08-11 13:48:19 +02:00
Thomas Lamprecht
4b1225a536 drop jslint lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 18:11:47 +02:00
Thomas Lamprecht
2aa774a27e ui: backup grid: use boxLabel type and VMID
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-03 16:26:25 +02:00
Dominik Csapak
844bd8b586 ui: add checkbox for vmid filter for backupview
instead of hardcoding the text 'type-id-' into the searchbar
to accomodate for the additional size, add an overflowHandler
to the toolbar (for very small display sizes)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-06-03 16:21:11 +02:00
Dominik Csapak
7d7b8509bb ui: Replication: use render_duration from widget-toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-06-02 11:47:43 +02:00
Thomas Lamprecht
7d673a026e ui: add date column in per-guest backup archive panel
Similar to commit f8211903de77e7e7f0959aeb10143f8a3129410b which
added this column to the storage content grid let's also add it here.
As we also base off the 'pve-storage-content' it's just a matter of
copying over the column definition 1:1

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-02-21 16:36:50 +01:00
Dietmar Maurer
15a992c217 storage content GUI: improve detection of backup volumes
Include new proxmox backup server volumes.
2020-02-19 14:02:05 +01:00
Thomas Lamprecht
ce0d324563 ui: FW/Alias: whitespace/indentation fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-01-22 12:40:35 +01:00
Thomas Lamprecht
971b5f69d0 ui: FW/Alias: make grid flex
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-01-22 12:40:15 +01:00
Thomas Lamprecht
64daf1dc45 ui: FW/Alias: make edit window wider to fit IPv6 CIDR
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-01-22 12:39:58 +01:00
Dominic Jäger
7126b80094 Fix #582: Add default delay for backups
A default of 5 seems like a reasonable delay for removing backups from
the GUI.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2019-07-25 13:23:40 +02:00
Thomas Lamprecht
c9823a6912 ui: FW log ratelimit: fix default value
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-05-16 10:30:34 +02:00
Christian Ebner
d898fa7a42 Allow to set the firewall log rate limit and burst from the UI
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-04-01 14:59:16 +02:00
Thomas Lamprecht
0cf38b0587 followup: move to advanced column
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-03-20 09:58:02 +01:00
Christian Ebner
aa56e96eac fix: # 2123 Logging of user defined firewall rules
This patch relies on the corresponding patch to pve-firewall, adding the user
defined log levels for firewall rules.

By this, the user can select a per-rule log level for self defined rules. These
are independent of the global log level, which is defined in the firewall options.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-03-20 08:55:28 +01:00
Christian Ebner
73c64dc513 1145 Warn if datacenter firewall is disabled
This warns the user that the datacenter firewall is disabled when editing the
host or the VM/CT firewall status.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-03-13 10:03:32 +01:00
Stoiko Ivanov
c41302b114 add ebtables option to cluster firewallsettings
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2018-06-06 15:52:11 +02:00