3736 Commits

Author SHA1 Message Date
Thomas Lamprecht
57820c4d9d ui/Parser: printPropertyString: simplify and always put defaultKey values first
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-08-02 16:20:12 +02:00
Thomas Lamprecht
0075b55aa6 ui/Parser: parsePropertyString: log errors to console
allows to catch bugs faster as we get a call trace and may see this
error even when our caller doesn't handle an undefined return value
from this method.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-08-02 16:20:12 +02:00
Stoiko Ivanov
0f60044255 ui/Parser: add generic functions property_strings
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2018-08-02 16:01:12 +02:00
Dominik Csapak
5cae151d8f add Directory list/create gui
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-08-02 12:42:17 +02:00
Dominik Csapak
7f794dcb22 add LVMThin list/create gui
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-08-02 12:42:04 +02:00
Dominik Csapak
6c4c85d018 add LVM List/Create Gui
only let the user change the name of the vg

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-08-02 12:41:52 +02:00
Dominik Csapak
676b5a9e9f move DiskSelector to its own file, for generic use
also set the default diskType to undefined and
change the api endpoint to /nodes/NODE/disks/list

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-08-02 12:40:45 +02:00
Thomas Lamprecht
2380c1f0f4 ui: storage: combine RBD external and hyperconverged add dialog
Combine both dialogues. This reduces storage choices from the
Storage -> Add menu, and thus improves usability.

We make the whole dialog also more intelligent by querying the
monitors, so that we can show them for the hyper converged case
keeping a similar interface for both cases. Further we can use this
to decide if a hyperconverged setup is possible at all.
While this information would also be available through the fact if
the pool selector has entries I wanted to show them anyway and could
make logic a bit easier using it.
2018-07-31 14:04:57 +02:00
Dominik Csapak
93c13afeb6 fix doubleclick on vm with spice console
allowSpice needs to be a real boolean, because of a
'=== true' check to open a spice console if allowed, so make it one here

this fixes the issue that a doubleclick on a tree item only opened
the novnc console even if spice is the default and the vm is spice
enabled

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-07-30 11:53:33 +02:00
Dietmar Maurer
8d88e66a2b bump version to 5.2-7 2018-07-27 11:47:38 +02:00
Thomas Lamprecht
eb65703b55 pveproxy: add link to extjs for api-viewer
allows us to remove the external loading of extjs from the cloudflare
cdn in pve-docs easier with having the external hosted version in
mind.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-27 11:09:21 +02:00
Dietmar Maurer
f48573317a correctly install PVE/CLI/pvesh.pm 2018-07-27 07:46:35 +02:00
Dietmar Maurer
233dbe039f pvesh: add standard_output_properties to set/create/delete
Most of those API calls return simple strings, so it does not really matter.
Nethertheless, some calls return complex data structures and we want to set
output format for them.
2018-07-27 07:34:49 +02:00
Dietmar Maurer
bd0e50532b pvesh cleanup: use a handler class - PVE/CLI/pvesh.pm 2018-07-26 15:20:15 +02:00
Dietmar Maurer
cd16ae07f5 pvenode: remove useless call to query_terminal_options 2018-07-26 13:12:58 +02:00
Dietmar Maurer
e1f897ea84 pvenode: use print_api_result to print acme account information 2018-07-26 13:09:08 +02:00
Dietmar Maurer
e3ca07b93f pvenode: use print_api_result to print certificate information 2018-07-26 13:09:08 +02:00
Dietmar Maurer
0feb0c5673 pvenode: fixup output formatting 2018-07-26 13:09:08 +02:00
Dietmar Maurer
b35fe93178 pvesh: implement 'ls' command 2018-07-26 13:09:08 +02:00
Dietmar Maurer
9bb8ce6be0 pvesh: do not use CLIHandler $option parameter, simplify code 2018-07-26 13:09:08 +02:00
Thomas Lamprecht
6df496780b ui: permissions: allow to select root path '/' directly
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-25 10:18:12 +02:00
Dominik Csapak
f92c0b1e30 set resize to 'off' for the novnc popup
this makes it easier to handle the resize parameter in novnc code

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-07-23 11:19:40 +02:00
Dominik Csapak
74f61c5038 improve xtermjs settings button behaviour
we now put a form around the fields/buttons and can track
the valid/dirty state, and use this for setting the button states

now the buttons are correctly enabled/disabled when the form
is dirty/valid/empty

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-07-19 10:38:01 +02:00
Thomas Lamprecht
9f999c04d8 nodeconfig acme-domain: allow domains starting with numbers
they are valid

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-12 10:36:59 +02:00
Dietmar Maurer
25b6579121 pvesh: use standard output options
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-11 11:27:13 +02:00
Dietmar Maurer
864a5845ec pvesh usage: correctly handle uri paramaeters, cleanups
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-11 11:27:13 +02:00
Dietmar Maurer
4012507fd7 pvesh usage: new option --returns to print result schema
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-11 11:27:13 +02:00
Dietmar Maurer
35ea1f7fab use new timestamp renderer for /nodes/<nodename>/time
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-11 11:27:13 +02:00
Wolfgang Bumiller
9730f1e239 fixup pvesh for changes in pve-common
In pve-common the following changes happened:
  0adee98 ("cli_handler: pass common output options as separate parameter")
  352b7a1 ("PVE::CLIFormatter - implement new output options")
We now get the format passed via an options hash in the
output function instead of seeing it as an api call
parameter.

Similarly, --quiet is now already handled there.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2018-07-11 10:51:14 +02:00
Dietmar Maurer
be96a59334 pvesh: complete rewrite using PVE::CLIHandler
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-11 10:36:32 +02:00
Dietmar Maurer
a306ed1315 pvesh - remove interactive readline mode
We have good command line completion and history with 'bash', so there is
no real need to duplicate this functionality.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-11 10:36:32 +02:00
Dietmar Maurer
22aa7e4a4f pvenode: fix print_api_result usage, avoid print_api_list
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-11 07:42:20 +02:00
Andrew Neitsch
44adc3c6ee Submit pool if non-empty in lxc CreateWizard
The lxc CreateWizard ignores the pool setting. That makes creating
containers impossible for users who are restricted to using a pool. This
patch fixes that.

Signed-off-by: Andrew Neitsch <andrew@neitsch.ca>
2018-07-11 07:25:48 +02:00
Thomas Lamprecht
bcd5f008eb bump version to 5.2-6
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-10 14:48:32 +02:00
Thomas Lamprecht
51681e0d7f debian/control: update pve-common version dependency
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-10 14:37:48 +02:00
Thomas Lamprecht
0f39c5865c pvenode: use new CLIFormatter options
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-10 14:37:48 +02:00
Dietmar Maurer
92b441a7d3 PVE/API2/Nodes.pm: document return properties for cluster node list.
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-10 14:16:23 +02:00
Thomas Lamprecht
4904965993 fixup: s/destriction/description/
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-10 14:16:23 +02:00
Dietmar Maurer
b2af687dad PVE/API2/Cluster.pm - document return properties for cluster resource list.
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
2018-07-10 13:23:28 +02:00
Thomas Lamprecht
e4867d90a0 ui: vm hotplug selector: refactor for sane formatting
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-06 08:05:48 +02:00
Alwin Antreich
54aef34585 Add cephfs to allowed storages for vzdump backup
Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2018-07-04 16:57:32 +02:00
Thomas Lamprecht
9f3e15b32d ui/storage: cifs: reoder fields
username, password and domain name are all related, they are non-pve
options related to accessing the CIFS storage and have all influence
on the pveCIFSScan component.
So group at kleast user and password together. But keep domain on the
right for the sake of balance.
Move the content type selector to the right, as the RBD and other
panels do.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-07-02 10:25:14 +02:00
Thomas Lamprecht
e3179cf3e5 ui/storage: cifs: exit early from username change cb on displaying
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-29 13:00:15 +02:00
Thomas Lamprecht
f3dd3fddf1 ui/storage: cifs: only allow entering a password if user is set
we ignore the password in the backend if no user is passed,
which can be very confusing for the user - or more important, me,
when testing cifs/storage stuff.

So change the mechanics slightly. Previously we changed the
allowBlank property of the password field if username was changed.
I set it to always required, but disable the whole field if we do not
have a username.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-29 12:55:28 +02:00
Thomas Lamprecht
574476c2b3 trivial: ui: cifs: cleanup unnecessary lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-29 12:54:00 +02:00
Dominik Csapak
0907b307ea whitespace fix
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-06-29 10:31:23 +02:00
Dominik Csapak
9d3e64a1f9 add task list/log/status to pvenode
and use the newly created print_api_* helpers for this

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-06-29 10:31:23 +02:00
Dominik Csapak
52e193170a task log: set default in the api call
we have the defaults documented here, so set them here too
otherwise if the default change in PVE::Tools, we probably forget to
update the api description

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-06-29 10:31:23 +02:00
Dominik Csapak
07adc3d5e4 node task list: set the defaults better
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-06-29 10:31:23 +02:00
Dominik Csapak
147ba3d54a add more api schema information for node task list and log
this makes for a better documentation

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-06-29 10:31:23 +02:00