135 Commits

Author SHA1 Message Date
Stefan Sterz
e98edb4c37 ui: make ceph charts change color more dynamically
add support for setting the background and text color via css. also
allows for dynamically switching the color when a theme change is
detected.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
2023-03-08 17:55:41 +01:00
Thomas Lamprecht
7a6de7fecc ui: config panel: xtype should be first property
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-10 13:44:03 +01:00
Thomas Lamprecht
8538f6f0b9 ui: config panel: ensure onlineHelp mapping targets are validated
our onlineHelp linter is pretty dumb and scans for used help
references heuristically, so add a small indirection to the mapping
of resource tree type to onlineHelp so that it detects those
references and thus enforces that they exists in pve-docs.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-10 12:32:41 +01:00
Thomas Lamprecht
7f74dabc9e ui: config panel: fix onlineHelp mapping targets
We currently do not support direct resolved links, and we also have
no stability guarantee for those, so the might change in pve-docs-

Switch to mapping to the chapter reference, which actually works and
is intended for stable help references.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-10 12:26:23 +01:00
Thomas Lamprecht
d5ef2ac832 fix #4455: ui: config panel: add missing onlineHelp mapping for SDN type
Besides adding the correct help mapping this also avoid a successive
null dereference exception.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-10 12:15:33 +01:00
Thomas Lamprecht
ea5d9c35c8 ui: config panel: refactor onlineHelp switch to object map
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-10 12:14:07 +01:00
Fiona Ebner
cf6b65a292 ui: {guest, node} summary: use correct unit for CPU usage
One could also think about showing something like '% of N CPUs', but
this can be inaccurate for older data, because the number of CPUs can
change.

Reported in the community forum:
https://forum.proxmox.com/threads/117362/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2022-11-07 11:20:59 +01:00
Thomas Lamprecht
5888ba939d ui: guest summary: fix qemu specific class name
call sites already used the 'pveGuestSummary'

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-09-12 17:01:35 +02:00
Stefan Sterz
742de03d5a ui: move NotesView panel and NotesEdit window to widget kit
this removes the NotesView panel and NotesEdit and replaces them with
with the version from the widget kit. requires a bump of the widget
toolkit.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
2022-04-13 11:35:30 +02:00
Fabian Ebner
4981660f2a ui: storage edit: retention: add max-protected-backups setting
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-06 14:07:21 +02:00
Fabian Ebner
392e3cf11d sorters: use correct property 'direction' and keep default 'ASC'
Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
didn't have an effect. The default is 'ASC' and it is arguably the
preferred direction for all affected sorters anyways.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-12-16 10:11:48 +01:00
Dominic Jäger
bd800443db ui: close #3504: Add datacenter notes
Like notes for nodes.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-11-09 18:33:47 +01:00
Dominik Csapak
5f219fd3ba ui: add MultiDiskPanel
this adds a new panel where a user can add multiple disks, intended
for use in the wizard.

Has a simple grid for displaying the already added disks and displays
a warning triangle if the disk is not valid.

this is a base panel for adding multiple disks/mps for vms/ct
respectively.

this combines the shared behavior and layout and defines the functions
that subclasses must define

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-11-05 09:50:36 +01:00
Thomas Lamprecht
57513f7639 ui: rename pveEditPruneInputPanel to pveBackupJobPrunePanel
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-09-08 12:56:15 +02:00
Fabian Ebner
9c4c579725 ui: prune edit: prepare for being re-used for backup jobs
1. Rename the isPBS variable to match the actual purpose. When editing
a backup job, the hint should not be shown, even if the storage is
PBS.

2. Allow specifying the text used for the fallback hint. For backup
jobs, the first fallback is the storage configuration, so the text
needs to be different there.

3. Make using keep-all=1 by default upon creation optional. For backup
jobs, the default should be "use fallback", i.e. no settings.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-09-07 11:13:18 +02:00
Fabian Ebner
1bc75c2f82 ui: factor out input panel for editing prune settings
To be re-used for configuring job-specific retention options for
backups.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-09-07 11:13:18 +02:00
Thomas Lamprecht
236b33e2b2 ui: notes view: render node and guest notes as Markdown
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 19:24:39 +02:00
Thomas Lamprecht
a78362cf06 ui: notes edit: set maxLength on text area
the backend will have actual explicit length limits on the
description properties (was limited indirectly through PUT/POST
request size limit of 64 KiB), so convey that limit also in the GUI.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 19:23:15 +02:00
Thomas Lamprecht
dbf3563fdf ui: notes view: code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 19:22:28 +02:00
Dominik Csapak
164a86abd5 ui: fix Guest Summary Notes height
fixes 'infinite' height of the guest notes, by setting the height on the
container a level up

the notes view itself is already scrollable, so if it is too large,
there'll be a scrollbar

this does not change anything for templates, as there we show nothing
under the notes and thus there the infinite height is ok

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-06-18 13:37:07 +02:00
Dominik Csapak
928028c1f6 ui: panel/ConfigPanel: return early on no selection
treelist technically allows deselection and this happens on destruction
in extjs 7.0 so simply return early to avoid errors accessing
components that do not exist anymore

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:43:08 +02:00
Dominik Csapak
c8d72c05ca ui: panel/ConfigPanel: change ui class to pve-nav
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:43:08 +02:00
Thomas Lamprecht
df22311b50 ui: nav: move bg-color override to CSS class
colors overrides really must not happen inline...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-23 18:04:16 +02:00
Dominic Jäger
90519f8a55 ui: panel/StatusPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
a9e7018401 ui: panel/RunningChart: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
193df2f373 ui: panel/NotesView: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
202298c10b ui: panel/IPSet: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
ee3903451e ui: panel/ConfigPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominik Csapak
c95917c263 ui: use pmxInfoWidget instead of pveInfoWidget
to prevent that they further diverge than they alread have
(pmxInfoWidget got an additional function that is compatible)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-23 10:37:55 +02:00
Dominik Csapak
e3c4b75d9e ui: panel/StatusView: use from widget-toolkit instead
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
2874be00f2 ui: Utils: use updateColumns from widget-toolkit
it was moved there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
a8ea1b6876 ui: use some icons from widget-toolkit
we moved them there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
1bd7bcdbf1 ui: Utils: use render functions from widget-toolkit
they live there now, so we can delete them here and use the ones from
widget-toolkit instead

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 18:34:34 +02:00
Thomas Lamprecht
e67d454a18 ui: use byte unit and power-of-two base for memory rrd graphs
To better match the gauge in the current status infobox in the same
summary panel, which is already using a format where KiB is 1024

the latter needs a (not yet bumped) widget toolkit update to 2.5-2 or
newer, just setting now to avoid forgetting it.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-15 19:31:03 +02:00
Thomas Lamprecht
53e3ea8488 ui: eslint: enforce "no-extra-parens" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:42:36 +01:00
Thomas Lamprecht
8058410f40 ui: eslint: fix various spacing related issues
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:39:15 +01:00
Thomas Lamprecht
f6710aac38 ui: eslint: fix trailing comma and comma related whitespaces errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:31:03 +01:00
Thomas Lamprecht
2a4971d8c9 ui: eslint: fix trailing spaces
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:29:55 +01:00
Dominik Csapak
8267aa6375 ui: fix usage of findRecord
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-26 10:52:07 +01:00
Fabian Ebner
a83c659a11 config panel: allow new nodes to be added later
in preparation for dynamically loading nodes for content-type-specific views.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-11-15 18:41:11 +01:00
Thomas Lamprecht
497c94f236 ui: running chart: assign getTime directly
no sense in doing it everywhere the Date variables are used, if it's
the only  thing we do on them.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:35:07 +02:00
Thomas Lamprecht
ca0267fdca ui: ceph status/running chart: disable trackRemoved
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:30:51 +02:00
Thomas Lamprecht
e75392ceb3 ui: running chart: avoid breakage if tooltip was on deleted record
if we cleanup records and there was a "stale" tooltip on one of them
we get an access on undefined value exception here

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:29:06 +02:00
Thomas Lamprecht
eb7f91977b ui: comment length cleanup to improve readability
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:27:45 +02:00
Thomas Lamprecht
3bbce3b8cd drop jslint lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 18:11:47 +02:00
Stefan Reiter
6751013a1b gui: never collapse notes for templates
There's no graphs on screen, so no reason to collapse the notes to save
space. Besides, it looked a bit funky expanding the notes on smaller
screens, since they always jumped to the bottom to fill the space...

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-05-06 16:24:37 +02:00
Thomas Lamprecht
300c0f736b fix #2552: ui: allow to collapse notes panel from guest summary
Allow to collapse and expand the "Notes" panel on the virtual guests
summary panel.

Further add a browser setting to control the default behavior, one
can chose from:
 * expand on show (default)
 * collapse on show
 * collapse if there are no notes

This way users can make slightly better use of the available screen
space for the guest status.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Co-developed-by: Stefan Reiter <s.reiter@proxmox.com>
2020-01-14 11:13:42 +01:00
Thomas Lamprecht
8dc7c7af99 grammar fix: s/does not exists/does not exist/g
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-13 12:51:22 +01:00
Dominik Csapak
ed3e711e29 gui: set minWidth for node/guest Summary
to make sure the panels are always readable

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-09 14:20:37 +01:00
Dominik Csapak
f973c5b262 gui: let users choose the number of columns
introduce a new browser setting, with which the users can choose between
the automatic mode of choosing columns, or always using 1/2/3 columns

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-09 14:20:37 +01:00