Proxmox/pve-network
5
0
Fork 0
mirror of git://git.proxmox.com/git/pve-network.git synced 2025-01-06 17:18:00 +03:00
Code Releases Activity

sdn: allow deletion of empty subnet with gateway

Browse Source 
If the gateway IP is last remaining IP in the subnet (in IPAM), allow
deleting the subnet.

Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
This commit is contained in:
Stefan Lendl 2023-11-17 15:02:27 +01:00 committed by Wolfgang Bumiller
parent a9107d35d2
commit 4a675ba3a3
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/PVE/Network/SDN/Ipams/PVEPlugin.pm
View File

@ -56,6 +56,16 @@ sub add_subnet {
die "$@" if $@;
}
sub only_gateway_remains {
my ($ips) = @_;
if (keys %{$ips} == 1 &&
(values %{$ips})[0]->{gateway} == 1) {
return 1;
}
return 0;
};
sub del_subnet {
my ($class, $plugin_config, $subnetid, $subnet) = @_;
@ -71,7 +81,11 @@ sub del_subnet {
my $dbsubnet = $dbzone->{subnets}->{$cidr};
die "subnet '$cidr' doesn't exist in IPAM DB\n" if !$dbsubnet;
die "cannot delete subnet '$cidr', not empty\n" if keys %{$dbsubnet->{ips}} > 0;
my $ips = $dbsubnet->{ips};
if (keys %{$ips} > 0 && !only_gateway_remains($ips)) {
die "cannot delete subnet '$cidr', not empty\n";
}
delete $dbzone->{subnets}->{$cidr};