Proxmox/qemu-server
5
0
Fork 0
mirror of git://git.proxmox.com/git/qemu-server.git synced 2025-01-21 18:03:56 +03:00
Code Releases Activity

add --description to systemd scope unit

Browse Source 
otherwise, long kvm commands lead to systemd unit files with
very long lines, with confuses the systemd unit file parser.

apparently systemd has a length limit for unit file lines and
(line-)breaks the description string at that point. since
the rest of the description is probably not a valid key/value
pair, this leads to warnings. the default semantics of systemd-run
is to use the executed command as description unless a description
is specified explicitly.

note that this behaviour of systemd could allow an attacker
with access to the VM configuration to craft a kvm commandline
that starts or stops arbitrary systemd units.
This commit is contained in:
Fabian Grünbichler 2016-05-13 15:36:51 +02:00 committed by Dietmar Maurer
parent 30983c3bac
commit 19333c9b82
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
PVE/QemuServer.pm
View File

@ -2762,6 +2762,7 @@ sub config_to_command {
push @$cmd, '--scope';
push @$cmd, '--slice', "qemu";
push @$cmd, '--unit', $vmid;
push @$cmd, '--description', "'Proxmox VE VM $vmid'";
# set KillMode=none, so that systemd don't kill those scopes
# at shutdown (pve-manager service should stop the VMs instead)
push @$cmd, '-p', "KillMode=none";

2
changelog.Debian
View File

@ -2,6 +2,8 @@ qemu-server (4.0-75) unstable; urgency=medium
* fix #975, use new keyAlias feature.
* add --description to systemd scope unit
-- Proxmox Support Team <support@proxmox.com> Wed, 11 May 2016 11:15:56 +0200
qemu-server (4.0-74) unstable; urgency=medium