From 1e28e8ba927a053052764a593fb2bef722e5a224 Mon Sep 17 00:00:00 2001 From: Alexandre Derumier Date: Fri, 24 Feb 2023 13:09:04 +0100 Subject: [PATCH] memory: rename qemu_dimm_list to qemu_memdevices_list current qemu_dimm_list can return any kind of memory devices. make it more generic, with an optionnal type device Signed-off-by: Alexandre Derumier --- PVE/QemuServer/Memory.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm index 89848210..7ad8fcbc 100644 --- a/PVE/QemuServer/Memory.pm +++ b/PVE/QemuServer/Memory.pm @@ -240,7 +240,7 @@ sub qemu_memory_hotplug { while (1) { eval { PVE::QemuServer::qemu_devicedel($vmid, $name) }; sleep 3; - my $dimm_list = qemu_dimm_list($vmid); + my $dimm_list = qemu_memdevices_list($vmid, 'dimm'); last if !$dimm_list->{$name}; raise_param_exc({ $name => "error unplug memory module" }) if $retry > 5; $retry++; @@ -255,14 +255,14 @@ sub qemu_memory_hotplug { } } -sub qemu_dimm_list { - my ($vmid) = @_; +sub qemu_memdevices_list { + my ($vmid, $type) = @_; my $dimmarray = mon_cmd($vmid, "query-memory-devices"); my $dimms = {}; foreach my $dimm (@$dimmarray) { - + next if $type && $dimm->{data}->{id} !~ /^$type(\d+)$/; $dimms->{$dimm->{data}->{id}}->{id} = $dimm->{data}->{id}; $dimms->{$dimm->{data}->{id}}->{node} = $dimm->{data}->{node}; $dimms->{$dimm->{data}->{id}}->{addr} = $dimm->{data}->{addr};