mirror of
git://git.proxmox.com/git/qemu-server.git
synced 2025-01-08 21:18:03 +03:00
use KillMode 'process' for systemd scope
KillMode 'none' is deprecated, and systemd loudly complains about that in the journal. To avoid the warning, but keep the behaviour the same, use KillMode 'process'. This mode does two things differently, which we have to stop it from doing: * it sends SIGTERM right when the scope is cancelled (e.g. on shutdown) -> but only to the "root" process, which in our case is the worker instance forking QEMU, so it is already dead by the time this happens * it sends SIGKILL to *all* children after a timeout -> can be avoided by setting either SendSIGKILL to false, or TimeoutStopUSec to infinity - for safety, we do both In my testing, this replicated the previous behaviour exactly, but without using the deprecated 'none' mode. Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
This commit is contained in:
parent
3f11f0d7e2
commit
354e61aacc
@ -5287,7 +5287,9 @@ sub vm_start_nolock {
|
||||
|
||||
my %properties = (
|
||||
Slice => 'qemu.slice',
|
||||
KillMode => 'none'
|
||||
KillMode => 'process',
|
||||
SendSIGKILL => 0,
|
||||
TimeoutStopUSec => ULONG_MAX, # infinity
|
||||
);
|
||||
|
||||
if (PVE::CGroup::cgroup_mode() == 2) {
|
||||
|
Loading…
Reference in New Issue
Block a user