Proxmox/qemu-server
5
0
Fork 0
mirror of git://git.proxmox.com/git/qemu-server.git synced 2025-01-22 22:03:55 +03:00
Code Releases Activity

config: update network: code-style & readability improvements

Browse Source 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2024-03-10 18:27:09 +01:00
parent 7c0f763d0c
commit 4f2404057e
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
PVE/QemuServer.pm
View File

@ -5254,13 +5254,14 @@ sub vmconfig_update_net {
safe_string_ne($oldnet->{macaddr}, $newnet->{macaddr}) ||
safe_num_ne($oldnet->{queues}, $newnet->{queues}) ||
safe_num_ne($oldnet->{mtu}, $newnet->{mtu}) ||
!($newnet->{bridge} && $oldnet->{bridge})) { # bridge/nat mode change
!($newnet->{bridge} && $oldnet->{bridge})
) { # bridge/nat mode change
# for non online change, we try to hot-unplug
die "skip\n" if !$hotplug;
vm_deviceunplug($vmid, $conf, $opt);
if($have_sdn) {
if ($have_sdn) {
PVE::Network::SDN::Vnets::del_ips_from_mac($oldnet->{bridge}, $oldnet->{macaddr}, $conf->{name});
}
@ -5272,12 +5273,14 @@ sub vmconfig_update_net {
if (safe_string_ne($oldnet->{bridge}, $newnet->{bridge}) ||
safe_num_ne($oldnet->{tag}, $newnet->{tag}) ||
safe_string_ne($oldnet->{trunks}, $newnet->{trunks}) ||
safe_num_ne($oldnet->{firewall}, $newnet->{firewall})) {
safe_num_ne($oldnet->{firewall}, $newnet->{firewall})
) {
PVE::Network::tap_unplug($iface);
#set link_down in guest if bridge or vlan change to notify guest (dhcp renew for example)
if (safe_string_ne($oldnet->{bridge}, $newnet->{bridge}) ||
safe_num_ne($oldnet->{tag}, $newnet->{tag})) {
safe_num_ne($oldnet->{tag}, $newnet->{tag})
) {
qemu_set_link_status($vmid, $opt, 0);
}
@ -5296,7 +5299,8 @@ sub vmconfig_update_net {
#set link_up in guest if bridge or vlan change to notify guest (dhcp renew for example)
if (safe_string_ne($oldnet->{bridge}, $newnet->{bridge}) ||
safe_num_ne($oldnet->{tag}, $newnet->{tag})) {
safe_num_ne($oldnet->{tag}, $newnet->{tag})
) {
qemu_set_link_status($vmid, $opt, 1);
}