5
0
mirror of git://git.proxmox.com/git/qemu-server.git synced 2025-03-09 08:58:25 +03:00

vzdump: factor out _get_task_devlist

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2020-03-19 18:32:00 +01:00
parent 09eb196b9e
commit 81dcd4799f

View File

@ -380,14 +380,8 @@ sub archive_pbs {
return;
}
my $devlist = '';
foreach my $di (@{$task->{disks}}) {
if ($di->{type} eq 'block' || $di->{type} eq 'file') {
$devlist .= $devlist ? ",$di->{qmdevice}" : $di->{qmdevice};
} else {
die "implement me";
}
}
# get list early so we die on unkown drive types before doing anything
my $devlist = _get_task_devlist($task);
my $stop_after_backup;
my $resume_on_backup;
@ -563,15 +557,7 @@ sub archive_vma {
return;
}
my $devlist = '';
foreach my $di (@{$task->{disks}}) {
if ($di->{type} eq 'block' || $di->{type} eq 'file') {
$devlist .= $devlist ? ",$di->{qmdevice}" : $di->{qmdevice};
} else {
die "implement me";
}
}
my $devlist = _get_task_devlist($task);
my $stop_after_backup;
my $resume_on_backup;
@ -773,6 +759,21 @@ sub archive_vma {
}
}
sub _get_task_devlist {
my ($task) = @_;
my $devlist = '';
foreach my $di (@{$task->{disks}}) {
if ($di->{type} eq 'block' || $di->{type} eq 'file') {
$devlist .= ',' if $devlist;
$devlist .= $di->{qmdevice};
} else {
die "implement me (type '$di->{type}')";
}
}
return $devlist;
}
sub snapshot {
my ($self, $task, $vmid) = @_;