3 Commits

Author	SHA1	Message	Date
Fiona Ebner	089aed811d	cfg2cmd: netdev: fix value for tx_queue_size ... Quoting from QEMU commit 4271f40383 ("virtio-net: correctly report maximum tx_queue_size value"): > Maximum value for tx_queue_size depends on the backend type. > 1024 for vDPA/vhost-user, 256 for all the others. > So the parameter is silently ignored and ethtool reports a different > value than the one provided by the user. Indeed, for a non-vDPA/vhost-user netdev, the guest will see TX: 256 instead of the specified 1024 here. With the mentioned QEMU commit (in master and will be part of 8.1), using 1024 will be a hard error: > Invalid tx_queue_size (= 1024), must be a power of 2 between 256 and 256 Since neither vhost-user, nor vhost-vdpa netdev types are exposed by Proxmox VE, just changing the limit to the correct 256 should be fine. No obvious issue during live-migration found. Fixes: 620d6b32 ("virtio-net: increase defaults rx|tx-queue-size to 1024") Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>	2023-07-27 13:14:12 +02:00
Alexandre Derumier	620d6b328f	virtio-net: increase defaults rx|tx-queue-size to 1024 ... This is reducing packet drop on high pps, and also needed for dpdk. Redhat already have use it by default in rhev and his openstack platform too since 2019. I'm using it in production since 6 months, I don't have seen performance regression. fix: (which ask for custom option, but setting it by default seem fine for me) https://bugzilla.proxmox.com/show_bug.cgi?id=1546 https://bugzilla.proxmox.com/show_bug.cgi?id=2349 Signed-off-by: Alexandre Derumier <aderumier@odiso.com>	2022-11-13 16:42:23 +01:00
Dominik Csapak	b1099442b6	tests: add tests for various combinations of configs for usb ... q35 + usb passthrough q35 + usb3 passthrough q35 + usb3 passthrough with new xhci controller old machine type + new usb config error old machine type + q35 + new usb config error old ostype (w2k) + new usb config error Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>	2022-11-11 08:52:01 +01:00