mirror of
git://git.proxmox.com/git/qemu-server.git
synced 2025-01-24 02:04:10 +03:00
6f0627d4bd
Fix races with ACPI-suspended VMs which could wake up during migration or during a suspend-mode backup. Revert prevention, of ACPI-suspended VMs automatically resuming after migration, introduced by 7ba974a6828d. The commit introduced a potential problem that causes a suspended VM that wakes up during migration to remain paused after the migration finishes. This can be fixed once QEMU preserves the 'suspended' runstate during migration (current patch on the qemu-devel list [0]) by checking for the 'suspended' runstate on the target after migration. Furthermore the commit increased the race window during the preparation of a suspend-mode backup, when a suspended VM wakes up between the vm_is_paused check in PVE::VZDump::QemuServer::prepare and PVE::VZDump::QemuServer::qga_fs_freeze. This causes the code to skip fs-freeze even if the VM has woken up, potentially leaving the file system in an inconsistent state. To prevent this, do not treat the suspended runstate as paused when migrating or archiving a VM. [0]: https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg05260.html Signed-off-by: Filip Schauer <f.schauer@proxmox.com> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com> [ TL: massage in Fiona's extra info into commit message ] Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
