mirror of
git://git.proxmox.com/git/qemu-server.git
synced 2025-01-10 01:18:01 +03:00
733234be04
The reason for why we did not do this in the first place was the fact that the "usb3" flag could be set in older qemu-server versions, we just ignored it but not filtered it out of the config.. That means there can be VMs out there which would now become a different HW layout, and issue for migration and live-snapshot restore. But, actually, while the "usb3" property could be set it allowed to start the VM in only if an additional USB devices was added to the VM with USB2, or the VM uses "q35" based machine - as else no "ehci" was available, and thus the "ignored" USB3 - SPICE could not get attached anywhere -> QEMU chickened out. And if a user had a configuration where this could started we have still a bit luck, live-migration was not possible as the "can't migrate VM which uses local devices:" check still hit, as in qemu-server older than 6.0-8 we explicitly checked for "spice" when seeing what usb device were not local, so a "spice,usb3=X" was always (luckily) wrongly detected as local device -> migration was blocked. So we only have one case left: restoring a live-snapshot. Here sadly there seems no way out, it was possible to do with a "spice,usb3=1" usb device, and thus all Snapshots taken on such VMs after they had a clean restart on PVE 6 (to have a machine version >= 4.0) are broken - but can be easily fixed by removing the "usb3=1" from the problematic snapshot config. As restoring a snapshot can be repeated more than once even on failure without rendering the snapshot or VM permanently unusable, this should be a reasonable compromise. I strongly believe that the chance is so small that no one is affected in practice and the property description mentioned that it was not supported. If anybody is affected on snapshot restore we can help them on a case-per-case basis. Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
13 lines
322 B
Plaintext
13 lines
322 B
Plaintext
# TEST: Test for SPICE with a USB3 based SPICE port added
|
|
# QEMU_VERSION: 4.0.0
|
|
cores: 2
|
|
memory: 768
|
|
name: spiceusb3
|
|
net0: virtio=A2:C0:43:77:08:A1,bridge=vmbr0
|
|
ostype: l26
|
|
scsihw: virtio-scsi-pci
|
|
smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465
|
|
vmgenid: c773c261-d800-4348-9f5d-167fadd53cf8
|
|
vga: qxl
|
|
usb1: spice,usb3=1
|