From 44b0f73c1eb04c956d5356010a9b84056bbce634 Mon Sep 17 00:00:00 2001
From: Alexander Meindl <a.meindl@alphanodes.com>
Date: Sun, 26 Nov 2023 17:28:11 +0100
Subject: [PATCH] skip with message on tests

---
 Gemfile                                    | 3 ++-
 test/functional/welcome_controller_test.rb | 4 ++--
 test/integration/library_test.rb           | 4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/Gemfile b/Gemfile
index 7cb5337c..64c6688a 100644
--- a/Gemfile
+++ b/Gemfile
@@ -16,6 +16,7 @@ if File.file? File.expand_path './.enable_dev', __dir__
     gem 'debug'
     gem 'marginalia'
     gem 'memory_profiler'
+    gem 'ruby-lsp'
   end
 end
 
@@ -43,7 +44,7 @@ end
 #   (this is used to not create conflicts with other plugins)
 if File.file? File.expand_path './.enable_test', __dir__
   group :development, :test do
-    gem 'active_record_doctor'
+    # gem 'active_record_doctor'
     gem 'bullet'
     gem 'rails_best_practices', require: false
   end
diff --git a/test/functional/welcome_controller_test.rb b/test/functional/welcome_controller_test.rb
index b3f4a1af..726b398d 100644
--- a/test/functional/welcome_controller_test.rb
+++ b/test/functional/welcome_controller_test.rb
@@ -76,7 +76,7 @@ class WelcomeControllerTest < Additionals::ControllerTest
   end
 
   def test_show_index_with_help_menu
-    skip if AdditionalsPlugin.active_hrm?
+    skip 'not tested if hrm is active' if AdditionalsPlugin.active_hrm?
 
     with_plugin_settings 'additionals', remove_help: 0 do
       @request.session[:user_id] = 1
@@ -87,7 +87,7 @@ class WelcomeControllerTest < Additionals::ControllerTest
   end
 
   def test_show_index_without_help_menu
-    skip if AdditionalsPlugin.active_hrm?
+    skip 'not tested if hrm is active' if AdditionalsPlugin.active_hrm?
 
     with_plugin_settings 'additionals', remove_help: 1 do
       @request.session[:user_id] = 1
diff --git a/test/integration/library_test.rb b/test/integration/library_test.rb
index 37b709fb..d854632d 100644
--- a/test/integration/library_test.rb
+++ b/test/integration/library_test.rb
@@ -21,7 +21,7 @@ class JavascriptLibraryTest < Additionals::IntegrationTest
            :queries
 
   def test_not_loaded_chart_css_library
-    skip if AdditionalsPlugin.active_reporting?
+    skip 'not tested if reporting is active' if AdditionalsPlugin.active_reporting?
 
     log_user 'admin', 'admin'
     get '/'
@@ -31,7 +31,7 @@ class JavascriptLibraryTest < Additionals::IntegrationTest
   end
 
   def test_not_loaded_chart_js_library
-    skip if AdditionalsPlugin.active_reporting?
+    skip 'not tested if reporting is active' if AdditionalsPlugin.active_reporting?
 
     log_user 'admin', 'admin'
     get '/'